From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E421F584F; Tue, 18 Feb 2025 20:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739910403; cv=none; b=FWERriUm6i33y78BOkts1ag6SaT5hIz/lmdMb+9M0q/f9SbYt/gn4wvpwdZ1u+4ZRDIqDildH3u1SV4drHkGfEbYZJPDG83YDXqg7Qc1sOatDb3sLf/qJM+2IoeMdmCpVXv7Znph0FRx9s1syKdsyM/HDdBBBku4j4Eu6/jg/Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739910403; c=relaxed/simple; bh=dFxUdaiFREVLNS+eX31rlW4f6w1Lg1h+ZAMFFRvfEF8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fHpHeESAWsa3EYtvdehXFTLLw8C2KhRJQidyTS2BouiWAFrtdRDlBnC3+Jhs91P/LVWMIZ2OzPG20tn8BvzwaBTBrrwkGrmS51Pbu1vAuB74LnakZGrfkLdlGG+g0wILmkYAxO5H6Fbv+RmpNnGHh0hlvf9mjAPalAMau9siNmg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MLVG7ptm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MLVG7ptm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32AC9C4CEE2; Tue, 18 Feb 2025 20:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739910403; bh=dFxUdaiFREVLNS+eX31rlW4f6w1Lg1h+ZAMFFRvfEF8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MLVG7ptmvOA7+szGUP0rNSf5asmBV2U4vRy733y88ZZuwJfd9MPG9j9euugVpjIXv t0/3c2yilSyMPWEm1/pGYPA2l/kjq1ifis58yveBxXMYkcIpnP58iFlOtCJwZBiEC3 p4yk9xdxpG6tB6AYgnnLxcjQUbTjUpgphixyXwFL01ax7BKoN/oDVtEvUznExUZH2X 88IHsM07P40Mwd60T7ebFMzkjuiFIlngNVxP+xMzEnrKMoYbxXxxmZ+PFLk7+6XArj 8Kt0sc8PdMnt9rcE7C4K4Qr39/sK1U2MSPdrZnHXkLuQiS2a/OWQsU05o2at8xiTz7 OuDSer+DI5ULA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniel Brackenbury , Jiri Kosina , Sasha Levin , jikos@kernel.org, bentiss@kernel.org, linux-input@vger.kernel.org Subject: [PATCH AUTOSEL 6.12 08/31] HID: topre: Fix n-key rollover on Realforce R3S TKL boards Date: Tue, 18 Feb 2025 15:25:54 -0500 Message-Id: <20250218202619.3592630-8-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250218202619.3592630-1-sashal@kernel.org> References: <20250218202619.3592630-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.12.15 Content-Transfer-Encoding: 8bit From: Daniel Brackenbury [ Upstream commit 9271af9d846c7e49c8709b58d5853cb73c00b193 ] Newer model R3* Topre Realforce keyboards share an issue with their older R2 cousins where a report descriptor fixup is needed in order for n-key rollover to work correctly, otherwise only 6-key rollover is available. This patch adds some new hardware IDs for the R3S 87-key keyboard and makes amendments to the existing hid-topre driver in order to change the correct byte in the new model. Signed-off-by: Daniel Brackenbury Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/Kconfig | 3 ++- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-topre.c | 7 +++++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index f8a56d6312425..4500d7653b05e 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -1154,7 +1154,8 @@ config HID_TOPRE tristate "Topre REALFORCE keyboards" depends on HID help - Say Y for N-key rollover support on Topre REALFORCE R2 108/87 key keyboards. + Say Y for N-key rollover support on Topre REALFORCE R2 108/87 key and + Topre REALFORCE R3S 87 key keyboards. config HID_THINGM tristate "ThingM blink(1) USB RGB LED" diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 6e8bcb1518bd7..a957ebcbc667a 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -1296,6 +1296,7 @@ #define USB_VENDOR_ID_TOPRE 0x0853 #define USB_DEVICE_ID_TOPRE_REALFORCE_R2_108 0x0148 #define USB_DEVICE_ID_TOPRE_REALFORCE_R2_87 0x0146 +#define USB_DEVICE_ID_TOPRE_REALFORCE_R3S_87 0x0313 #define USB_VENDOR_ID_TOPSEED 0x0766 #define USB_DEVICE_ID_TOPSEED_CYBERLINK 0x0204 diff --git a/drivers/hid/hid-topre.c b/drivers/hid/hid-topre.c index 848361f6225df..ccedf8721722e 100644 --- a/drivers/hid/hid-topre.c +++ b/drivers/hid/hid-topre.c @@ -29,6 +29,11 @@ static const __u8 *topre_report_fixup(struct hid_device *hdev, __u8 *rdesc, hid_info(hdev, "fixing up Topre REALFORCE keyboard report descriptor\n"); rdesc[72] = 0x02; + } else if (*rsize >= 106 && rdesc[28] == 0x29 && rdesc[29] == 0xe7 && + rdesc[30] == 0x81 && rdesc[31] == 0x00) { + hid_info(hdev, + "fixing up Topre REALFORCE keyboard report descriptor\n"); + rdesc[31] = 0x02; } return rdesc; } @@ -38,6 +43,8 @@ static const struct hid_device_id topre_id_table[] = { USB_DEVICE_ID_TOPRE_REALFORCE_R2_108) }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPRE, USB_DEVICE_ID_TOPRE_REALFORCE_R2_87) }, + { HID_USB_DEVICE(USB_VENDOR_ID_TOPRE, + USB_DEVICE_ID_TOPRE_REALFORCE_R3S_87) }, { } }; MODULE_DEVICE_TABLE(hid, topre_id_table); -- 2.39.5