From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Elizabeth Figura <zfigura@codeweavers.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, wine-devel@winehq.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] ntsync: Check wait count based on byte size.
Date: Wed, 19 Feb 2025 15:25:27 +0100 [thread overview]
Message-ID: <2025021906-retainer-trustless-bd1d@gregkh> (raw)
In-Reply-To: <20250219001920.210847-1-zfigura@codeweavers.com>
On Tue, Feb 18, 2025 at 06:19:20PM -0600, Elizabeth Figura wrote:
> GCC versions below 13 incorrectly detect the copy size as being static and too
> small to fit in the "fds" array. Work around this by explicitly calculating the
> size and returning EINVAL based on that, instead of based on the object count.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502072019.LYoCR9bF-lkp@intel.com/
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
>
> --
>
> Suggested-by as per Arnd's request, but the only thing I changed was preserving
> array_size() [as noted by Geert in the linked thread]. I tested and found no
> regressions.
You forgot to sign-off on this commit :(
Can you resend it please with that fixed?
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-19 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 0:19 [PATCH] ntsync: Check wait count based on byte size Elizabeth Figura
2025-02-19 14:25 ` Greg Kroah-Hartman [this message]
2025-02-20 19:30 ` Elizabeth Figura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021906-retainer-trustless-bd1d@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=wine-devel@winehq.org \
--cc=zfigura@codeweavers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox