From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings
Date: Wed, 19 Feb 2025 17:46:29 -0800 [thread overview]
Message-ID: <20250219174629.4791c1e9@kernel.org> (raw)
In-Reply-To: <99543a40-2a57-4c10-8876-cde08cb15199@gmail.com>
On Wed, 19 Feb 2025 14:14:35 +0200 Tariq Toukan wrote:
> On 18/02/2025 23:13, Jakub Kicinski wrote:
> > On Tue, 18 Feb 2025 17:53:14 +0200 Tariq Toukan wrote:
> >> Maybe it wasn't clear enough.
> >> We prefer the original patch, and provided the Reviewed-by tag for it.
> >
> > Can you explain what do you mean by "cleaner"?
> > I like the alternative much more.
>
> Cleaner in the sense that it doesn't touch existing code in en_rx.c
> (datapath), and has shorter dereferences for the inner umr_wqe fields, like:
> umr_wqe->ctrl
> vs.
> umr_wqe->hdr.ctrl
IMO that's minor, not sufficient to justify struct_group_tagged()
next prev parent reply other threads:[~2025-02-20 1:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 2:57 [PATCH][next] net/mlx5e: Avoid a hundred -Wflex-array-member-not-at-end warnings Gustavo A. R. Silva
2025-02-04 6:09 ` Michal Swiatkowski
2025-02-06 4:37 ` Gustavo A. R. Silva
2025-02-06 7:25 ` Tariq Toukan
2025-02-18 8:14 ` Gustavo A. R. Silva
2025-02-18 9:49 ` Tariq Toukan
2025-02-18 15:37 ` Andrew Lunn
2025-02-18 15:53 ` Tariq Toukan
2025-02-18 21:13 ` Jakub Kicinski
2025-02-19 12:14 ` Tariq Toukan
2025-02-20 1:46 ` Jakub Kicinski [this message]
2025-02-20 7:41 ` Tariq Toukan
2025-02-20 18:26 ` Jakub Kicinski
2025-02-20 21:49 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219174629.4791c1e9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gustavo@embeddedor.com \
--cc=gustavoars@kernel.org \
--cc=leon@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox