From: Oleg Nesterov <oleg@redhat.com>
To: Kees Cook <kees@kernel.org>
Cc: Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] yama: don't abuse rcu_read_lock/get_task_struct in yama_task_prctl()
Date: Wed, 19 Feb 2025 22:42:18 +0100 [thread overview]
Message-ID: <20250219214218.GF5948@redhat.com> (raw)
In-Reply-To: <20250219210042.GE5948@redhat.com>
Damn, sorry for the spam ;)
On 02/19, Oleg Nesterov wrote:
>
> Forgot to say...
>
> with or without this patch the usage of ptrace_relation->tracer/tracee
> doesn't look right (safe) to me... but probably I missed something
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Yes I did. I didn't realize that put_task_struct(tracer/tracee) calls
security_task_free() -> yama_task_free().
Sorry fo the noise.
Oleg.
next prev parent reply other threads:[~2025-02-19 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 16:14 [PATCH] yama: don't abuse rcu_read_lock/get_task_struct in yama_task_prctl() Oleg Nesterov
2025-02-19 19:33 ` Kees Cook
2025-02-19 20:17 ` Oleg Nesterov
2025-02-19 21:00 ` Oleg Nesterov
2025-02-19 21:42 ` Oleg Nesterov [this message]
2025-03-04 23:53 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219214218.GF5948@redhat.com \
--to=oleg@redhat.com \
--cc=jmorris@namei.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox