From: Jeff Chen <jeff.chen_1@nxp.com>
To: linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, briannorris@chromium.org,
johannes@sipsolutions.net, francesco@dolcini.it,
tsung-hsien.hsieh@nxp.com, s.hauer@pengutronix.de,
Jeff Chen <jeff.chen_1@nxp.com>
Subject: [PATCH v3 2/2] wifi: mwifiex: Part B of resolving the failure in downloading calibration data.
Date: Thu, 20 Feb 2025 14:11:43 +0800 [thread overview]
Message-ID: <20250220061143.1417420-3-jeff.chen_1@nxp.com> (raw)
In-Reply-To: <20250220061143.1417420-1-jeff.chen_1@nxp.com>
This patch resolves an issue where calibration data was being
released before the download process. Without this fix, the
calibration data would not be downloaded at all.
This patch is a split from the previous submission.
Signed-off-by: Jeff Chen <jeff.chen_1@nxp.com>
---
drivers/net/wireless/marvell/mwifiex/main.c | 4 ----
drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 6 +++++-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/main.c b/drivers/net/wireless/marvell/mwifiex/main.c
index 45eecb5f643b..b07cb302a00c 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.c
+++ b/drivers/net/wireless/marvell/mwifiex/main.c
@@ -691,10 +691,6 @@ static int _mwifiex_fw_dpc(const struct firmware *firmware, void *context)
init_failed = true;
done:
- if (adapter->cal_data) {
- release_firmware(adapter->cal_data);
- adapter->cal_data = NULL;
- }
if (adapter->firmware) {
release_firmware(adapter->firmware);
adapter->firmware = NULL;
diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
index 6e7b2b5c7dc5..2ba5269b0f3a 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
@@ -2297,9 +2297,13 @@ int mwifiex_sta_init_cmd(struct mwifiex_private *priv, u8 first_sta, bool init)
"marvell,caldata");
}
- if (adapter->cal_data)
+ if (adapter->cal_data) {
mwifiex_send_cmd(priv, HostCmd_CMD_CFG_DATA,
HostCmd_ACT_GEN_SET, 0, NULL, true);
+ release_firmware(adapter->cal_data);
+ adapter->cal_data = NULL;
+ }
+
/* Read MAC address from HW */
ret = mwifiex_send_cmd(priv, HostCmd_CMD_GET_HW_SPEC,
--
2.34.1
next prev parent reply other threads:[~2025-02-20 6:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 1:28 [PATCH v2 1/2] wifi: mwifiex: Resolve the failure in downloading calibration data Jeff Chen
2025-02-05 1:28 ` [PATCH v2 2/2] wifi: mwifiex: Fix HT40 bandwidth issue Jeff Chen
2025-03-06 10:37 ` Francesco Dolcini
2025-03-14 3:06 ` [EXT] " Jeff Chen
2025-02-11 13:31 ` [PATCH v2 1/2] wifi: mwifiex: Resolve the failure in downloading calibration data Johannes Berg
2025-02-20 6:11 ` [PATCH v3 0/2] Resolve the failure in downloading Jeff Chen
2025-02-20 6:11 ` [PATCH v3 1/2] wifi: mwifiex: Part A of resolving the failure in downloading calibration data Jeff Chen
2025-03-06 10:43 ` Francesco Dolcini
2025-03-07 16:40 ` [EXT] " Jeff Chen
2025-03-18 5:07 ` [PATCH v4 0/2] wifi: mwifiex: Fix RF calibration data handling issues Jeff Chen
2025-03-18 5:07 ` [PATCH v4 1/2] wifi: mwifiex: Fix premature release of RF calibration data Jeff Chen
2025-03-19 16:28 ` Francesco Dolcini
2025-03-25 16:43 ` [EXT] " Jeff Chen
2025-03-25 16:45 ` Johannes Berg
2025-03-25 22:55 ` Brian Norris
2025-03-26 12:18 ` Francesco Dolcini
2025-03-26 15:23 ` Brian Norris
2025-03-27 17:26 ` Jeff Chen
2025-03-18 5:07 ` [PATCH v4 2/2] wifi: mwifiex: Fix RF calibration data download from file Jeff Chen
2025-03-19 16:31 ` Francesco Dolcini
2025-03-24 16:47 ` [EXT] " Jeff Chen
2025-03-24 7:02 ` Sascha Hauer
2025-03-24 16:57 ` [EXT] " Jeff Chen
2025-02-20 6:11 ` Jeff Chen [this message]
2025-02-20 8:21 ` [PATCH v3 0/2] Resolve the failure in downloading Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220061143.1417420-3-jeff.chen_1@nxp.com \
--to=jeff.chen_1@nxp.com \
--cc=briannorris@chromium.org \
--cc=francesco@dolcini.it \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=tsung-hsien.hsieh@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox