Re: [PATCH v3 2/6] platform: arm64: add Huawei Matebook E Go EC driver

Guenter Roeck
2025-01-13T18:34:20Z

On 1/13/25 09:50, Pengyu Luo wrote:
> There are three variants of which Huawei released the first two
> simultaneously.
>
> Huawei Matebook E Go LTE(sc8180x), codename seems to be gaokun2.
> Huawei Matebook E Go(sc8280xp@3.0GHz), codename must be gaokun3. (see [1])
> Huawei Matebook E Go 2023(sc8280xp@2.69GHz), codename should be also gaokun3.
>
> Adding support for the latter two variants for now, this driver should
> also work for the sc8180x variant according to acpi table files, but I
> don't have the device to test yet.
>
> Different from other Qualcomm Snapdragon sc8280xp based machines, the
> Huawei Matebook E Go uses an embedded controller while others use
> a system called PMIC GLink. This embedded controller can be used to
> perform a set of various functions, including, but not limited to:
>
> - Battery and charger monitoring;
> - Charge control and smart charge;
> - Fn_lock settings;
> - Tablet lid status;
> - Temperature sensors;
> - USB Type-C notifications (ports orientation, DP alt mode HPD);
> - USB Type-C PD (according to observation, up to 48w).
>
> Add a driver for the EC which creates devices for UCSI and power supply
> devices.
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=219645
>
> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
> ---
...
> + ec->hwmon_dev = hwmon_device_register_with_groups(dev, "gaokun_ec_hwmon",
> + ec, gaokun_ec_hwmon_groups);

This API function is deprecated.

Guenter