From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 474451E571A for ; Thu, 20 Feb 2025 07:19:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740035992; cv=none; b=EZIxf91hDecJv1ymEIOBbPvGqXIl4zgqM05ma4pAq30CBEkKdJ3WeR7e0wKMPZgFcqlSq0LFzAyEeUVYS8wHcJ4b8Zlx9gNJwnXZuPwz+ffRRR4fpMu+u+7vq/kAFv8N793PQ8qw96+/FeajRhc+q+PMAlYrjlqp7FPXJyAaz5Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740035992; c=relaxed/simple; bh=dSKE5I1F5l6I4pWkjzFMa6oZu20U6ZVKkb/GOJ9jS3o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HqML6BUf1YV7D2Wb6Y4vrPwIgrnaQ2bzmnpCNwKAr4jw96hsrE9pEIW1lS9r/Swqb/8xaXlF3kUC+gkHUUKtSacJhjhNDNfIOWuBHpUjy4ktNA/IeJvnG2xPsQfC+NPdGqsS36vyePdQ6HlGH6TdzvfeOsKqSrK+Fut6xdFbDQY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VNLZAx69; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VNLZAx69" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-220c92c857aso10921945ad.0 for ; Wed, 19 Feb 2025 23:19:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740035990; x=1740640790; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=+Ur9dFsKFbvJEs8mC6dKdEyGV45W+SbQs+6opIdZpbs=; b=VNLZAx69oomZ2UsY/9Cxo311gLJEFuu4zoHEWnn1HdOYJ9H10PWen//VB7OkXM8aji indTno01AIY1BtmqmZYus2N/06rkmcBhlI30jb5ajRX/zpxpUB6+mNx7tNSNqIVgRJVf vNZ30uYjL2fChu7wE58nPLJ3nBi7J7uOnv75wFOStLEwCDpAui1WcThIDnvjarRAJYQu /uvJzscP7FiTToS7UrurzWbRm3lRQpnROxA6I23IzQUHXaJMXHg50pnfbP2KSNNB7W96 byLYJ26/72OF5AUZ85DUTrdOqZOtqL5mZ2euyH3V0FMx2hx+s1YW+gm5glkFveDzBGSw 0d+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740035990; x=1740640790; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Ur9dFsKFbvJEs8mC6dKdEyGV45W+SbQs+6opIdZpbs=; b=hwARHqR7P1i/sxgZzz9DHsvicEMefX4bwMzV1Y8tALxYCfDY5BLHkF9hgG/PrxTALw Sb+/3COr/QHb3QYZH2M/XYZoipwZc70nYhx9v1KX0uHYYMbIiZqmn5V4DMRhEiBaraGT CpRf/68mp3Rhb6aKrHsYjJvr1lEyskBah1lk0g/w/8vSgmOibo4OVC7msPvwOnguyRgS nG3Dt26agYByEseH2UKsHiKjIBhfRxjLqNwDsp3hW+fAJx95VDfaJACae1Xf7pWSciSd GOJT2yX0KdqrVRR+L5kWetmqU5ggVSbh60WKvkmHUhk7qPBw4MVwvUqoEKgR476kaMMP MosA== X-Forwarded-Encrypted: i=1; AJvYcCXgI/3j4e3AuDpslETsCaepJTMgGJ15eiC3QTtYZhkTf+p3ZJ1wCLvQbAhgdAE0JEPlZng5wzmYRy+cK78=@vger.kernel.org X-Gm-Message-State: AOJu0YwISjbSn4ovWQAo4FEelNE9XwtsvEL1y0TrfqeN7VQBquO/Kv0N LKDxihocC+xeA+Xh7kz6kqRg7WpkesAxlZOD1efIp0DdT6i/+Xa1UugkpcgXoA== X-Gm-Gg: ASbGncsU32m9ayM5Skfaz959hZeb6SAuWfBK4eajInD0UuWI0/+f0CdKvywDv7NWeqE 8AZFPKsYJRVMLLbYsaSfAcwUDqPE/a/Ri2Gx6wQDe5xSkdxcOzoti7+xO0uqH6PlWI5XXyqiZWM BytB0k0RquRlGk5nXtgky2AVxvhSVhMRa6VZlQTzvbyarQe0SXlnVkJujKXzgqX/QHhoMKa21k5 /5dG/iD+jklc6WYoZR5pSlb9LESKNCOCBDOVYvFrBSzQBPo8ghu2qOVO5gLeTazpd1QS5YmtX85 bf0jihmvGNAUjQctXO97Ke8qVg== X-Google-Smtp-Source: AGHT+IF3yihejjwT/v8s1qaCn8nd+GpEMzld00Wlnl4a36L6UHNc/5ltRo3ZjwkDna6NDtWQ/sG8kQ== X-Received: by 2002:a17:902:f54d:b0:216:271d:e06c with SMTP id d9443c01a7336-2218c3db4d8mr38128005ad.4.1740035990566; Wed, 19 Feb 2025 23:19:50 -0800 (PST) Received: from thinkpad ([120.60.70.244]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-220d537bd1asm115277265ad.102.2025.02.19.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2025 23:19:50 -0800 (PST) Date: Thu, 20 Feb 2025 12:49:43 +0530 From: Manivannan Sadhasivam To: Dmitry Baryshkov Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Mrinmay Sarkar , Bjorn Andersson , Konrad Dybcio , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] dt-bindings: PCI: qcom-ep: describe optional IOMMU Message-ID: <20250220071943.edn6q65ijmeldnag@thinkpad> References: <20250217-sar2130p-pci-v1-0-94b20ec70a14@linaro.org> <20250217-sar2130p-pci-v1-1-94b20ec70a14@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250217-sar2130p-pci-v1-1-94b20ec70a14@linaro.org> On Mon, Feb 17, 2025 at 08:56:13PM +0200, Dmitry Baryshkov wrote: > Platforms which use eDMA for PCIe EP transfers (like SA8775P) also use > IOMMU in order to setup transfer windows. eDMA has nothing to do with IOMMU. In fact, it is not clear on what IOMMU does on the endpoint side since we do not assign SID based on the RID from RC. But the binding should describe it anyway since IOMMU does sit between DDR and PCIe IP. - Mani > Fix the schema in order to > allow specifying the IOMMU. > > Fixes: 9d3d5e75f31c ("dt-bindings: PCI: qcom-ep: Add support for SA8775P SoC") > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > index 1226ee5d08d1ae909b07b0d78014618c4c74e9a8..800accdf5947e7178ad80f0759cf53111be1a814 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml > @@ -75,6 +75,9 @@ properties: > - const: doorbell > - const: dma > > + iommus: > + maxItems: 1 > + > reset-gpios: > description: GPIO used as PERST# input signal > maxItems: 1 > @@ -233,6 +236,20 @@ allOf: > minItems: 3 > maxItems: 3 > > + - if: > + properties: > + compatible: > + contains: > + const: qcom,sdx55-pcie-ep > + then: > + properties: > + iommus: > + false > + > + else: > + required: > + - iommus > + > unevaluatedProperties: false > > examples: > > -- > 2.39.5 > -- மணிவண்ணன் சதாசிவம்