* [PATCH v2] mfd: ene-kb3930: Fix potential NULL pointer dereference
@ 2025-02-13 2:25 Chenyuan Yang
2025-02-20 14:58 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Chenyuan Yang @ 2025-02-13 2:25 UTC (permalink / raw)
To: lee, lkundrak; +Cc: linux-kernel, zzjas, Chenyuan Yang
The off_gpios could be NULL. Add missing check in the kb3930_probe().
This is similar to the issue fixed in commit b1ba8bcb2d1f
("backlight: hx8357: Fix potential NULL pointer dereference").
Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Suggested-by: Lee Jones <lee@kernel.org>
---
drivers/mfd/ene-kb3930.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index fa0ad2f14a39..9460a67acb0b 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -162,7 +162,7 @@ static int kb3930_probe(struct i2c_client *client)
devm_gpiod_get_array_optional(dev, "off", GPIOD_IN);
if (IS_ERR(ddata->off_gpios))
return PTR_ERR(ddata->off_gpios);
- if (ddata->off_gpios->ndescs < 2) {
+ if (ddata->off_gpios && ddata->off_gpios->ndescs < 2) {
dev_err(dev, "invalid off-gpios property\n");
return -EINVAL;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] mfd: ene-kb3930: Fix potential NULL pointer dereference
2025-02-13 2:25 [PATCH v2] mfd: ene-kb3930: Fix potential NULL pointer dereference Chenyuan Yang
@ 2025-02-20 14:58 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2025-02-20 14:58 UTC (permalink / raw)
To: Chenyuan Yang; +Cc: lkundrak, linux-kernel, zzjas
On Wed, 12 Feb 2025, Chenyuan Yang wrote:
> The off_gpios could be NULL. Add missing check in the kb3930_probe().
> This is similar to the issue fixed in commit b1ba8bcb2d1f
> ("backlight: hx8357: Fix potential NULL pointer dereference").
>
> Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller")
> Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
> Suggested-by: Lee Jones <lee@kernel.org>
> ---
> drivers/mfd/ene-kb3930.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please submit one more time with the following line above the tags:
Cc: stable@vger.kernel.org
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-20 14:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-13 2:25 [PATCH v2] mfd: ene-kb3930: Fix potential NULL pointer dereference Chenyuan Yang
2025-02-20 14:58 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox