RE: [Intel-wired-lan] [PATCH iwl-next v4 5/6] ice: support egress drop rules on PF

Romanowski, Rafal
2025-03-11T10:26:48Z

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Simon Horman
> Sent: Thursday, February 20, 2025 3:59 PM
> To: Zaremba, Larysa <larysa.zaremba@intel.com>
> Cc: Nguyen, Anthony L <anthony.l.nguyen@intel.com>; intel-wired-
> lan@lists.osuosl.org; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>;
> Andrew Lunn <andrew+netdev@lunn.ch>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Michal Swiatkowski
> <michal.swiatkowski@linux.intel.com>; Pacuszka, MateuszX
> <mateuszx.pacuszka@intel.com>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4 5/6] ice: support egress drop
> rules on PF
>
> On Fri, Feb 14, 2025 at 09:50:39AM +0100, Larysa Zaremba wrote:
> > tc clsact qdisc allows us to add offloaded egress rules with commands
> > such as the following one:
> >
> > tc filter add dev <ifname> egress protocol lldp flower skip_sw action
> > drop
> >
> > Support the egress rule drop action when added to PF, with a few caveats:
> > * in switchdev mode, all PF traffic has to go uplink with an exception for
> > LLDP that can be delegated to a single VSI at a time
> > * in legacy mode, we cannot delegate LLDP functionality to another VSI, so
> > such packets from PF should not be blocked.
> >
> > Also, simplify the rule direction logic, it was previously derived
> > from actions, but actually can be inherited from the tc block (and
> > flipped in case of port representors).
> >
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
>
> Reviewed-by: Simon Horman <horms@kernel.org>

Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>