public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: ritvikfoss@gmail.com
To: linux-kernel@vger.kernel.org, ricardo@marliere.net
Cc: skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH v2] scripts/checksyscalls.sh: Add usage message, fix -Wno-error
Date: Thu, 20 Feb 2025 20:44:14 +0530	[thread overview]
Message-ID: <20250220151414.8003-1-ritvikfoss@gmail.com> (raw)
In-Reply-To: <20250220105940.5241-1-ritvikfoss@gmail.com>

From: Ritvik Gupta <ritvikfoss@gmail.com>

Currently 'scripts/checksyscalls.sh' does not
provide guidance when executed without specifying
a compiler, instead it attempts to execute
'-Wno-error' parameter as a command,
resulting in 'Wno-error: Command not found' error.

This patch adds a usage message that is displayed
when no compiler is provided as parameter to
improve clarity.

Signed-off-by: Ritvik Gupta <ritvikfoss@gmail.com>
---
Changes in v2:
    - Make the script posix compliant
    - Fixed formatting

Thanks for reviewing!

 scripts/checksyscalls.sh | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/scripts/checksyscalls.sh b/scripts/checksyscalls.sh
index 1e5d2eeb726d..96cba9f79249 100755
--- a/scripts/checksyscalls.sh
+++ b/scripts/checksyscalls.sh
@@ -10,6 +10,22 @@
 # checksyscalls.sh gcc gcc-options
 #
 
+usage() {
+cat << EOF
+Usage: $0 <compiler> [compiler-options]
+
+Example:
+  $0 gcc
+EOF
+
+exit 1
+}
+
+if [ $# -eq 0 ]; then
+	echo "Error: No compiler provided."
+	usage
+fi
+
 ignore_list() {
 cat << EOF
 #include <asm/types.h>
-- 
2.48.1


      parent reply	other threads:[~2025-02-20 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 10:59 [PATCH] scripts/checksyscalls.sh: Add usage message, fix -Wno-error ritvikfoss
2025-02-20 11:52 ` Ricardo B. Marlière
2025-02-20 15:14 ` ritvikfoss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250220151414.8003-1-ritvikfoss@gmail.com \
    --to=ritvikfoss@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo@marliere.net \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox