From: Lee Jones <lee@kernel.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] leds: aw200xx: don't use return with gpiod_set_value() variants
Date: Thu, 20 Feb 2025 15:19:00 +0000 [thread overview]
Message-ID: <20250220151900.GF778229@google.com> (raw)
In-Reply-To: <20250212085918.6902-1-brgl@bgdev.pl>
On Wed, 12 Feb 2025, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> While it now returns void, it will soon be converted to return an
> integer instead. Don't do `return gpiod_set...`.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502121512.CmoMg9Q7-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/leds/leds-aw200xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lee Jones <lee@kernel.org>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-02-20 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 8:59 [PATCH] leds: aw200xx: don't use return with gpiod_set_value() variants Bartosz Golaszewski
2025-02-12 9:02 ` Bartosz Golaszewski
2025-02-12 15:55 ` Lee Jones
2025-02-12 16:39 ` Bartosz Golaszewski
2025-02-17 10:44 ` Bartosz Golaszewski
2025-02-20 15:19 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220151900.GF778229@google.com \
--to=lee@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pavel@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox