From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F381B15A858; Thu, 20 Feb 2025 19:19:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740079182; cv=none; b=abmYATMLJR0ejm1y/Ti7VQ7sDgtB6EoxwnECX4nF+fExxImOgRQD2pCLI4rd9rzCUvG31o5W06IOWURJJByKr71FwH1OifNTWuCgfYnGso27XVLgN/bAip8HVXWWooyu2pBUwQq1t6Y3xnYdxHMzbgEiVpbzT35yrPFLKwk4pO4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740079182; c=relaxed/simple; bh=+0OClTSDtciyZQXNExzuhepJzGzEk7ZP1QX/R7XxbUs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MA02/4dV5lEHSyWn2tWq+neJddk6CiJTKLNQBXC4LVodM2RLVGWEJ7winc8W6kcfoNjQo6ONzXGO1khGS2vnSe1M0uzQlaRqBc5MD/I7HiNpJq+g1UPlU073cLKO24KqnhTlLkjFERo3TIxFkVmismkZjlSBKHVXyD8TGB1/rSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Li1wYMRm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Li1wYMRm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5697CC4CED1; Thu, 20 Feb 2025 19:19:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740079181; bh=+0OClTSDtciyZQXNExzuhepJzGzEk7ZP1QX/R7XxbUs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Li1wYMRmL9KK6l4WaYL0PcSVJKqrcCa10Y6PHxcMEmTa6dtMdvVsK9SC3SnMWeIT7 9PC+m6PbqUF0f2cSKFxu2XNJ9j4JN/0wfhzFnlSYwM2hMJTnzd4tfnI3u8ZuexbzLr h/5+jea8bk80FA7Sif/DJo+n5mb4iQFTc33VmwYqD4vk7Ex1KxBXvj5jvpXoUT6HZr ds3TV1OFRECgpfpbFNhSbCL7JcxmHFv8GZTq/NeiSyR4YHxXJWDb4lV3LO3LkqjTuZ lRVDG+fDGn4xH4rpa0fSsjMSlxhn4olEvUQX2gU5Vi76hsjkLwgmkP7O5x0y6sCEFz GLVhh/JbmCuIA== Date: Thu, 20 Feb 2025 19:19:39 +0000 From: Eric Biggers To: Bartosz Golaszewski Cc: neil.armstrong@linaro.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Thara Gopinath , Herbert Xu , "David S. Miller" , Stanimir Varbanov Subject: Re: [PATCH 9/9] crypto: qce - switch to using a mutex Message-ID: <20250220191939.GA2098877@google.com> References: <20241203-crypto-qce-refactor-v1-0-c5901d2dd45c@linaro.org> <20241203-crypto-qce-refactor-v1-9-c5901d2dd45c@linaro.org> <20250118080604.GA721573@sol.localdomain> <20250118175502.GA66612@sol.localdomain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 20, 2025 at 10:14:20AM +0100, Bartosz Golaszewski wrote: > On Mon, Jan 20, 2025 at 2:46 PM Bartosz Golaszewski wrote: > > > > On Sat, Jan 18, 2025 at 6:55 PM Eric Biggers wrote: > > > > > > On Sat, Jan 18, 2025 at 10:28:26AM +0100, Bartosz Golaszewski wrote: > > > > I was testing with kcapi-speed and cryptsetup benchmark. I've never > > > > seen any errors. > > > > > > > > Is this after my changes only or did it exist before? You're testing > > > > with the tcrypt module? How are you inserting it exactly? What params? > > > > > > Those are all benchmarks, not tests. The tests run at registration time if you > > > just enable the kconfig options for them: > > > > > > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > > > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > > > > > > The test failures and KASAN error occur on mainline too, so yes they occur > > > before your patchset too. > > > > > > > > > > > > > I personally still struggle to understand how this driver could plausibly be > > > > > useful when the software crypto has no issues, is much faster, and is much > > > > > better tested. What is motivating having this driver in the kernel? > > > > > > > > We want to use it in conjunction with the upcoming scminvoke (for > > > > loading TAs and invoking objects - used to program the keys into the > > > > QCE) to support the DRM use-case for decrypting streaming data inside > > > > secure buffers upstream. > > > > > > Notably lacking is any claim that any of the current features of the driver are > > > actually useful. > > > > > > > Noted. I'm still quite early into working on the upstream-bound code > > supporting the streaming use-case but I will consider a proposal to > > remove existing features that are better provided by ARM CE. > > > > Thanks, > > Bartosz > > Just an FYI, I was informed by Qualcomm that upcoming platforms will > contain an upgrade to this IP and it will be up to 3x faster than ARM > CE. I suspect that is measured under some ideal condition that won't be reached in the real world, but we'll see. - Eric