Re: [PATCH 0/2] Add support for MT8196 video encoder

Nicolas Dufresne
2025-02-21T15:53:27Z

Hi,

Le vendredi 21 février 2025 à 11:10 +0800, Irui Wang a écrit :
> This patch series adds support for MT8196 video encoder. The changes
> include introducing a new encoder driver interface and add support
> for the
> new encoder driver encoding process.

thanks for your contribution. In general, when adding new HW support,
we would like to see in your cover letter your v4l2-compliance report.

Since this is a firmware based encoder, we also want to know how the
process with uploading your firmware in linux-firmware is going. We can
do reviews ahead of this of course, but merging depends on having
firmware upstream. We did some favours in the past and it worked for
many SoC, but things seems to have changed lately with the MT8188
firmware situation. Hope you understand this concern.

regards,
Nicolas

>
> Irui Wang (2):
>   media: mediatek: encoder: Add a new encoder driver interface
>   media: mediatek: encoder: Add support for common driver encode
> process
>
>  .../platform/mediatek/vcodec/encoder/Makefile |   1 +
>  .../mediatek/vcodec/encoder/mtk_vcodec_enc.c  |   2 +
>  .../vcodec/encoder/mtk_vcodec_enc_drv.h       |   3 +
>  .../vcodec/encoder/venc/venc_common_if.c      | 704
> ++++++++++++++++++
>  .../mediatek/vcodec/encoder/venc_drv_if.c     |   3 +-
>  .../mediatek/vcodec/encoder/venc_drv_if.h     |   3 +
>  .../mediatek/vcodec/encoder/venc_ipi_msg.h    |  26 +
>  .../mediatek/vcodec/encoder/venc_vpu_if.c     |  37 +-
>  8 files changed, 764 insertions(+), 15 deletions(-)
>  create mode 100644
> drivers/media/platform/mediatek/vcodec/encoder/venc/venc_common_if.c
>