Re: [PATCH 0/2] Add support for MT8196 video encoder

Irui Wang (王瑞)
2025-02-24T02:11:48Z

Dear Nicolas,

Thanks for your help reviewing.

On Fri, 2025-02-21 at 10:53 -0500, Nicolas Dufresne wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> Hi,
>
> Le vendredi 21 février 2025 à 11:10 +0800, Irui Wang a écrit :
> > This patch series adds support for MT8196 video encoder. The
> > changes
> > include introducing a new encoder driver interface and add support
> > for the
> > new encoder driver encoding process.
>
> thanks for your contribution. In general, when adding new HW support,
> we would like to see in your cover letter your v4l2-compliance
> report.

OK, we will add the v4l2-compliance report in next version.

>
> Since this is a firmware based encoder, we also want to know how the
> process with uploading your firmware in linux-firmware is going. We
> can
> do reviews ahead of this of course, but merging depends on having
> firmware upstream. We did some favours in the past and it worked for
> many SoC, but things seems to have changed lately with the MT8188
> firmware situation. Hope you understand this concern.

Thanks for your ahead of reviewing, we also want to send our patches
for reviewing in advance to save some times. Certainly, the patches
should be merged depends on firmware, we could do both things
simultaneously.

Thank you again for your help.
>
> regards,
> Nicolas
>
> >
> > Irui Wang (2):
> > media: mediatek: encoder: Add a new encoder driver interface
> > media: mediatek: encoder: Add support for common driver encode
> > process
> >
> > .../platform/mediatek/vcodec/encoder/Makefile | 1 +
> > .../mediatek/vcodec/encoder/mtk_vcodec_enc.c | 2 +
> > .../vcodec/encoder/mtk_vcodec_enc_drv.h | 3 +
> > .../vcodec/encoder/venc/venc_common_if.c | 704
> > ++++++++++++++++++
> > .../mediatek/vcodec/encoder/venc_drv_if.c | 3 +-
> > .../mediatek/vcodec/encoder/venc_drv_if.h | 3 +
> > .../mediatek/vcodec/encoder/venc_ipi_msg.h | 26 +
> > .../mediatek/vcodec/encoder/venc_vpu_if.c | 37 +-
> > 8 files changed, 764 insertions(+), 15 deletions(-)
> > create mode 100644
> > drivers/media/platform/mediatek/vcodec/encoder/venc/venc_common_if.
> > c
> >