From: Kees Cook <kees@kernel.org>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: Ronald Monthero <debug.penguin32@gmail.com>,
al@alarsen.net, gustavoars@kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] qnx4: fix to avoid panic due to buffer overflow
Date: Fri, 21 Feb 2025 09:38:11 -0800 [thread overview]
Message-ID: <202502210936.8A4F1AB@keescook> (raw)
In-Reply-To: <gfnn2owle4abn3bhhrmesubed5asqxdicuzypfrcvchz7wbwyv@bdyn7bkpwwut>
On Fri, Feb 21, 2025 at 03:51:23PM +0100, Mateusz Guzik wrote:
> On Sun, Nov 12, 2023 at 07:53:53PM +1000, Ronald Monthero wrote:
> > qnx4 dir name length can vary to be of maximum size
> > QNX4_NAME_MAX or QNX4_SHORT_NAME_MAX depending on whether
> > 'link info' entry is stored and the status byte is set.
> > So to avoid buffer overflow check di_fname length
> > fetched from (struct qnx4_inode_entry *)
> > before use in strlen to avoid buffer overflow.
> >
>
> Inspired by removals of reiserfs and sysv I decided to try to whack
> qnx4.
I have no strong opinion here beyond just pointing out that it appears
that the qnx4 fs is still extant in the world. QNX itself is still alive
and well and using this filesystem based on what I can find.
-Kees
--
Kees Cook
next prev parent reply other threads:[~2025-02-21 17:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 9:53 [PATCH] qnx4: fix to avoid panic due to buffer overflow Ronald Monthero
2023-11-12 16:16 ` Anders Larsen
2023-11-13 9:25 ` Ronald Monthero
2023-11-13 15:40 ` Anders Larsen
2023-11-14 14:38 ` Ronald Monthero
2023-11-16 14:29 ` Kees Cook
2023-11-16 14:58 ` Kees Cook
2023-11-16 16:48 ` Anders Larsen
2023-11-16 18:26 ` Kees Cook
2023-11-18 8:38 ` Ronald Monthero
2025-02-21 14:51 ` Mateusz Guzik
2025-02-21 17:38 ` Kees Cook [this message]
2025-02-22 12:12 ` Mateusz Guzik
2025-02-22 15:17 ` Kees Cook
2025-02-22 16:36 ` Mateusz Guzik
2025-02-24 11:26 ` Christian Brauner
2025-02-23 0:19 ` Al Viro
2025-02-24 11:56 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502210936.8A4F1AB@keescook \
--to=kees@kernel.org \
--cc=al@alarsen.net \
--cc=brauner@kernel.org \
--cc=debug.penguin32@gmail.com \
--cc=gustavoars@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox