Re: [PATCH 2/2] RDMA/mlx5: convert timeouts to secs_to_jiffies()

Jason Gunthorpe
2025-04-07T18:06:45Z

On Wed, Feb 19, 2025 at 09:36:40PM +0000, Easwar Hariharan wrote:
> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
> secs_to_jiffies(). As the value here is a multiple of 1000, use
> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication.
>
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
>
> @depends on patch@
> expression E;
> @@
>
> -msecs_to_jiffies(E * 1000)
> +secs_to_jiffies(E)
>
> -msecs_to_jiffies(E * MSEC_PER_SEC)
> +secs_to_jiffies(E)
>
> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Applied just this patch, Ye's version of mlx4 is more complete.

Thanks
Jason