Re: [PATCH v13 04/14] x86/mm: use INVLPGB for kernel TLB flushes

Nadav Amit
2025-02-24T12:44:52Z

> On 24 Feb 2025, at 14:31, Borislav Petkov <bp@alien8.de> wrote:
>
> On Sun, Feb 23, 2025 at 02:48:54PM -0500, Rik van Riel wrote:
>> Use broadcast TLB invalidation for kernel addresses when available.
>>
>> Remove the need to send IPIs for kernel TLB flushes.
>>
>> Signed-off-by: Rik van Riel <riel@surriel.com>
>> Reviewed-by: Nadav Amit <nadav.amit@gmail.com>

Nothing concrete against this patch, but I do not remember reviewing it
thoroughly, and I do not see that I sent any “Reviewed-by” tag for it
before, so please remove it. I only reviewed thoroughly and gave
“reviewed-by” for patch 9.

[ I would note at this opportunity that while I managed to convince myself
patch 9 is safe, I personally would have considered taking a more defensive
approach there. I may reiterate it there. ]