Re: [PATCH net-next] selftests/net: ensure mptcp is enabled in netns

Matthieu Baerts
2025-02-24T13:53:18Z

Hi Hangbin, Davide,

On 24/02/2025 10:40, Hangbin Liu wrote:
> Some distributions may not enable MPTCP by default. All other MPTCP tests
> source mptcp_lib.sh to ensure MPTCP is enabled before testing. However,
> the ip_local_port_range test is the only one that does not include this
> step.

This modification is OK for me, but would it not be time to stop
patching the kernel of these distributions to disable MPTCP by default?

As far as I know, only one Linux distribution is doing that, and that's
the one supporting MPTCP the best :)
It was making sense when MPTCP was backported to older kernels, but now
that v6.12 is used as a new base, it probably no longer makes sense, no?

> Let's also ensure MPTCP is enabled in netns for ip_local_port_range so
> that it passes on all distributions.

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
--