Re: [PATCH net-next v5 06/12] net: pse-pd: Add support for budget evaluation strategies

Jakub Kicinski
2025-03-04T01:12:28Z

On Mon, 3 Mar 2025 14:40:51 +0100 Kory Maincent wrote:
> > Ok, I assume we are talking about different things. I mean - not port
> > specific configurations and diagnostic, will have different interface.
> >
> > BUDGET_EVAL_STRAT is port specific. HP and Cisco implement it as port
> > specific. PD692x0 Protocol manual describe it as port specific too:
> > 3.3.6 Set BT Port Parameters
> > Bits [3..0]—BT port PM mode
> > 0x0: The port power that is used for power management purposes is
> > dynamic (Iport x Vmain).
> > 0x1: The port power that is used for power management purposes is port
> > TPPL_BT.
> > 0x2: The port power that is used for power management purposes is
> > dynamic for non LLDP/CDP/Autoclass ports and TPPL_BT for
> > LLDP/CDP/Autoclass ports. 0xF: Do not change settings.
>
> I don't really understand how that can be port specific when the power budget is
> per PD69208 manager. Maybe I am missing information here.

+1

> > So, I assume, critical components are missing anyway.
>
> As we are not supporting the budget method configured by the user in this
> series, I agreed we should not add any uAPI related to it that could be broken
> or confusing later.
>
> I will remove it and send v6.

v6 sounds like a good idea.