Re: [PATCH net-next v5 02/12] net: pse-pd: Add support for reporting events

Kory Maincent
2025-02-24T18:19:23Z

On Mon, 24 Feb 2025 12:02:28 +0100
Kory Maincent <kory.maincent@bootlin.com> wrote:

> Hello Oleksij,
>
> On Fri, 21 Feb 2025 09:50:33 +0100
> Oleksij Rempel <o.rempel@pengutronix.de> wrote:
>
> > Hi Kory,
> >
> > On Tue, Feb 18, 2025 at 05:19:06PM +0100, Kory Maincent wrote:
> > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > >
> > > Add support for devm_pse_irq_helper() to register PSE interrupts. This
> > > aims to report events such as over-current or over-temperature conditions
> > > similarly to how the regulator API handles them but using a specific PSE
> > > ethtool netlink socket.
> >
> > Thank you for your work. Here some comments.
> >
> > ...
> >
> > > --- a/drivers/net/mdio/fwnode_mdio.c
> > > +++ b/drivers/net/mdio/fwnode_mdio.c
> > > @@ -18,7 +18,8 @@ MODULE_LICENSE("GPL");
> > > MODULE_DESCRIPTION("FWNODE MDIO bus (Ethernet PHY) accessors");
> > >
> > > static struct pse_control *
> > > -fwnode_find_pse_control(struct fwnode_handle *fwnode)
> > > +fwnode_find_pse_control(struct fwnode_handle *fwnode,
> > > + struct phy_device *phydev)
> > > {
> >
> > This change seems to be not directly related to the commit message.
> > Is it the preparation for the multi-phy support?
>
> I need to save the phy_device related to PSE control to use the right network
> interface for the ethtool notification. (ethnl_pse_send_ntf())
> Indeed I have not described this in the commit message.

In fact, there is another solution. We can go over all the PHYs and look for
the one that matches the psec pointer.

Mmh it is maybe better, it will avoid saving the phy_device pointer into
the newly attached_phydev.

I will go for it in v6.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering