From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4CB268689 for ; Tue, 25 Feb 2025 15:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740496158; cv=none; b=AfPUc+x17fNLCG94/2i2Q/iLPZvbdE4JTROM2kvA8M473oBLHnB8kdpLqZSTf8sNC+c+DSc5jew5qv2w8V0vetZVkfZUVoVgnM83Q0gOA3qgTR9dwre66gINYbCgAwqCts1jCaqP7MkBfliBFkEjU9fPFkyudk4YHWhBBhaW1wc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740496158; c=relaxed/simple; bh=cIRZUoXqiqNLw/a/W7MMBUFb3l8m44OG4ew0GRkK8/A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FIv0oAXiwMdF94roKpqXNE7M2Axbt0BPo2+eJ2RFKwO+Nos0qfhJsqHwzQ8LKRBXKSOIhrpPte+vVPKWVmaCZjVP7Sq1A/1gBRq5+aFj39WH7WFHhEVjdHUUiFhFMgxVj/eiSIyIPoJyjU2LKlZgsbsUR+TYtrluiyoEDgoUTTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=gkULc+1A; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="gkULc+1A" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1740496152; bh=cIRZUoXqiqNLw/a/W7MMBUFb3l8m44OG4ew0GRkK8/A=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gkULc+1AWxgA+2fDCzxKVIccOFF7MGJkzxjKdngHRbCKokB0+AmACmMgvauxBPmVR //HehxCYgm8QP7FD7o6nAO+h+TdqomEy5oRCYxLdCQIGalLNk2OKQmN8aID/ANgOBb uq2yakzXSxh+EzigpOkEl0OfbsS6HLiIpmzysgLQADdFtzjg8YRfKzBnTm95I8qYzV 0iCf2ZV7x2NvcVminDhlT8G6gNicotp+xLDgxSMRCRUjBKog549jUGA2xq+xm+uD6X L+c8hhCTRlqxo5ifH7sUy6m6x91MpBSkfvyQJMQ/vREmUl0WSaEofoLQm+rVfHmgoL lYU/PEx6nkH9A== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 6245017E088B; Tue, 25 Feb 2025 16:09:12 +0100 (CET) Date: Tue, 25 Feb 2025 16:09:08 +0100 From: Boris Brezillon To: =?UTF-8?B?QWRyacOhbg==?= Larumbe Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steven Price , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liviu Dudau , kernel@collabora.com Subject: Re: [RFC PATCH 7/7] drm/panfrost/panthor: Take sparse objects into account for fdinfo Message-ID: <20250225160908.4c5a8a41@collabora.com> In-Reply-To: <20250218232552.3450939-8-adrian.larumbe@collabora.com> References: <20250218232552.3450939-1-adrian.larumbe@collabora.com> <20250218232552.3450939-8-adrian.larumbe@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 18 Feb 2025 23:25:37 +0000 Adri=C3=A1n Larumbe wrote: > Because of the alternative definition of the 'pages' field in shmem after= adding > support for sparse allocations, the logic for deciding whether pages are > available must be expanded. >=20 > Signed-off-by: Adri=C3=A1n Larumbe > --- > drivers/gpu/drm/panfrost/panfrost_gem.c | 4 +++- > drivers/gpu/drm/panthor/panthor_gem.c | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panfrost/panfrost_gem.c b/drivers/gpu/drm/pa= nfrost/panfrost_gem.c > index 0cda2c4e524f..ced2fdee74ab 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_gem.c > +++ b/drivers/gpu/drm/panfrost/panfrost_gem.c > @@ -200,7 +200,9 @@ static enum drm_gem_object_status panfrost_gem_status= (struct drm_gem_object *obj > struct panfrost_gem_object *bo =3D to_panfrost_bo(obj); > enum drm_gem_object_status res =3D 0; > =20 > - if (bo->base.base.import_attach || bo->base.pages) > + if (bo->base.base.import_attach || > + (!bo->base.sparse && bo->base.pages) || > + (bo->base.sparse && !xa_empty(&bo->base.xapages))) > res |=3D DRM_GEM_OBJECT_RESIDENT; Looks like we want some kind of drm_gem_shmem_is_populated() helper, and have all drivers doing this pages !=3D NULL test patched to use this new helper as part of the patch introducing sparse shmem GEMs. > =20 > if (bo->base.madv =3D=3D PANFROST_MADV_DONTNEED) > diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/pant= hor/panthor_gem.c > index 8244a4e6c2a2..8dbaf766bd79 100644 > --- a/drivers/gpu/drm/panthor/panthor_gem.c > +++ b/drivers/gpu/drm/panthor/panthor_gem.c > @@ -155,7 +155,9 @@ static enum drm_gem_object_status panthor_gem_status(= struct drm_gem_object *obj) > struct panthor_gem_object *bo =3D to_panthor_bo(obj); > enum drm_gem_object_status res =3D 0; > =20 > - if (bo->base.base.import_attach || bo->base.pages) > + if (bo->base.base.import_attach || > + (!bo->base.sparse && bo->base.pages) || > + (bo->base.sparse && !xa_empty(&bo->base.xapages))) > res |=3D DRM_GEM_OBJECT_RESIDENT; > =20 > return res;