public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Qais Yousef <qyousef@layalina.io>
To: Chen Yu <yu.chen.surf@foxmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	zihan zhou <15645113830zzh@gmail.com>,
	oe-lkp@lists.linux.dev, kernel test robot <oliver.sang@intel.com>,
	lkp@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	aubrey.li@linux.intel.com, yu.c.chen@intel.com
Subject: Re: [tip:sched/core] [sched]  2ae891b826:  hackbench.throughput 6.2% regression
Date: Tue, 25 Feb 2025 23:10:14 +0000	[thread overview]
Message-ID: <20250225231014.yztrap5ihain3cd2@airbuntu> (raw)
In-Reply-To: <tencent_1A4C28B62DA5726C31A985601B07F664250A@qq.com>

On 02/25/25 23:35, Chen Yu wrote:
> On 2025-02-25 at 13:42:20 +0000, Qais Yousef wrote:
> > On 02/25/25 21:15, Chen Yu wrote:
> > > On 2025-02-25 at 13:27:05 +0100, Peter Zijlstra wrote:
> > > > On Tue, Feb 25, 2025 at 05:31:34PM +0800, Chen Yu wrote:
> > > > 
> > > > > 
> > > > > But consider that the 6% regression is not that high, and the user might customize
> > > > > base_slice via debugfs on-demand, we can keep an eye on this and revist it in the
> > > > > future(we have encountered some SPECjbb regression due to over-preemption).
> > > > 
> > > > You can specify a per-task slice using sched_attr::sched_runtime. Also
> > > > see commit 857b158dc5e8 ("sched/eevdf: Use sched_attr::sched_runtime to
> > > > set request/slice suggestion")
> > > > 
> > > >
> > > 
> > > Thanks, we'll have a try during the next test cycle.
> > 
> > Could you also try with HRTICK enabled?
> > 
> > 	echo HRTICK | sudo tee /sys/kernel/debug/sched/features
> 
> Sure. Is HRTICK supposed to encourage preemption? I thought
> hackbench might be sensitive to preemption(downgrading).

Yes my bad, I don't know why I read this as preemption was happening later not
earlier. Please ignore me then.

Thanks

--
Qais Yousef

      reply	other threads:[~2025-02-25 23:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25  2:32 [tip:sched/core] [sched] 2ae891b826: hackbench.throughput 6.2% regression kernel test robot
2025-02-25  9:31 ` Chen Yu
2025-02-25  9:45   ` Vincent Guittot
2025-02-25 10:15     ` Chen Yu
2025-02-25 12:27   ` Peter Zijlstra
2025-02-25 13:15     ` Chen Yu
2025-02-25 13:42       ` Qais Yousef
2025-02-25 15:35         ` Chen Yu
2025-02-25 23:10           ` Qais Yousef [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250225231014.yztrap5ihain3cd2@airbuntu \
    --to=qyousef@layalina.io \
    --cc=15645113830zzh@gmail.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=peterz@infradead.org \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    --cc=yu.c.chen@intel.com \
    --cc=yu.chen.surf@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox