Re: [PATCH net-next v4 1/1] ppp: Fix KMSAN warning by initializing 2-byte header

Jiayuan Chen
2025-02-28T04:55:50Z

On Thu, Feb 27, 2025 at 05:48:12PM -0800, Jakub Kicinski wrote:
> On Wed, 26 Feb 2025 09:36:58 +0800 Jiayuan Chen wrote:
> > The PPP driver adds an extra 2-byte header to enable socket filters to run
> Could you add:
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> And combine the cover letter with the commit message?
> For a single-patch postings cover letter is not necessary.
>
> > + *(__be16 *)skb_push(skb, 2) = htons(PPP_FILTER_OUTBOUND_TAG);
> > if (ppp->pass_filter &&
> > bpf_prog_run(ppp->pass_filter, skb) == 0) {
> > if (ppp->debug & 1)
>
> The exact same problem seems to be present in ppp_receive_nonmp_frame()
> please fix them both.
> --
> pw-bot: cr
Thanks, Jakub! I'll do that.

I was previously worried that the commit message would be too long,
so I put the detailed information in the cover letter instead. I'll make
the commit message more concise.