From: Mario Limonciello <superm1@kernel.org>
To: "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
Perry Yuan <perry.yuan@amd.com>
Cc: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>,
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)),
linux-pm@vger.kernel.org (open list:CPU FREQUENCY SCALING
FRAMEWORK), Mario Limonciello <mario.limonciello@amd.com>,
Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Subject: [PATCH v5 19/19] cpufreq/amd-pstate: Drop actions in amd_pstate_epp_cpu_offline()
Date: Wed, 26 Feb 2025 01:49:34 -0600 [thread overview]
Message-ID: <20250226074934.1667721-20-superm1@kernel.org> (raw)
In-Reply-To: <20250226074934.1667721-1-superm1@kernel.org>
From: Mario Limonciello <mario.limonciello@amd.com>
When the CPU goes offline there is no need to change the CPPC request
because the CPU will go into the deepest C-state it supports already.
Actually changing the CPPC request when it goes offline messes up the
cached values and can lead to the wrong values being restored when
it comes back.
Instead drop the actions and if the CPU comes back online let
amd_pstate_epp_set_policy() restore it to expected values.
Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v5:
* Reword commit message
* Add tag
---
drivers/cpufreq/amd-pstate.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 24a1f9e129b61..4a364ae9b56a1 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -1580,14 +1580,7 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy)
static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)
{
- struct amd_cpudata *cpudata = policy->driver_data;
- union perf_cached perf = READ_ONCE(cpudata->perf);
-
- if (cpudata->suspended)
- return 0;
-
- return amd_pstate_update_perf(policy, perf.lowest_perf, 0, perf.lowest_perf,
- AMD_CPPC_EPP_BALANCE_POWERSAVE, false);
+ return 0;
}
static int amd_pstate_epp_suspend(struct cpufreq_policy *policy)
--
2.43.0
next prev parent reply other threads:[~2025-02-26 7:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 7:49 [PATCH v5 00/19] amd-pstate cleanups Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 01/19] cpufreq/amd-pstate: Invalidate cppc_req_cached during suspend Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 02/19] cpufreq/amd-pstate: Show a warning when a CPU fails to setup Mario Limonciello
2025-03-18 7:58 ` Paul Menzel
2025-02-26 7:49 ` [PATCH v5 03/19] cpufreq/amd-pstate: Drop min and max cached frequencies Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 04/19] cpufreq/amd-pstate: Move perf values into a union Mario Limonciello
2025-02-27 12:59 ` kernel test robot
2025-02-27 20:09 ` Mario Limonciello
2025-03-01 7:02 ` Dhananjay Ugwekar
2025-02-26 7:49 ` [PATCH v5 05/19] cpufreq/amd-pstate: Overhaul locking Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 06/19] cpufreq/amd-pstate: Drop `cppc_cap1_cached` Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 07/19] cpufreq/amd-pstate-ut: Use _free macro to free put policy Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 08/19] cpufreq/amd-pstate-ut: Allow lowest nonlinear and lowest to be the same Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 09/19] cpufreq/amd-pstate-ut: Drop SUCCESS and FAIL enums Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 10/19] cpufreq/amd-pstate-ut: Run on all of the correct CPUs Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 11/19] cpufreq/amd-pstate-ut: Adjust variable scope Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 12/19] cpufreq/amd-pstate: Replace all AMD_CPPC_* macros with masks Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 13/19] cpufreq/amd-pstate: Cache CPPC request in shared mem case too Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 14/19] cpufreq/amd-pstate: Move all EPP tracing into *_update_perf and *_set_epp functions Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 15/19] cpufreq/amd-pstate: Update cppc_req_cached for shared mem EPP writes Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 16/19] cpufreq/amd-pstate: Drop debug statements for policy setting Mario Limonciello
2025-02-26 7:49 ` [PATCH v5 17/19] cpufreq/amd-pstate: Rework CPPC enabling Mario Limonciello
2025-03-01 7:03 ` Dhananjay Ugwekar
2025-03-04 5:08 ` Gautham R. Shenoy
2025-02-26 7:49 ` [PATCH v5 18/19] cpufreq/amd-pstate: Stop caching EPP Mario Limonciello
2025-02-26 7:49 ` Mario Limonciello [this message]
2025-03-04 5:11 ` [PATCH v5 19/19] cpufreq/amd-pstate: Drop actions in amd_pstate_epp_cpu_offline() Gautham R. Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250226074934.1667721-20-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=Dhananjay.Ugwekar@amd.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox