Re: [PATCH 2/8] tracing: tprobe-events: Reject invalid tracepoint name

Steven Rostedt
2025-02-26T15:10:12Z

On Wed, 26 Feb 2025 15:18:54 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
>
> Commit 57a7e6de9e30 ("tracing/fprobe: Support raw tracepoints on
> future loaded modules") allows user to set a tprobe on non-exist
> tracepoint but it does not check the tracepoint name is acceptable.
> So it leads tprobe has a wrong character for events (e.g. with
> subsystem prefix). In this case, the event is not shown in the
> events directory.
>
> Reject such invalid tracepoint name.
>
> The tracepoint name must consist of alphabet or digit or '_'.
>
> Fixes: 57a7e6de9e30 ("tracing/fprobe: Support raw tracepoints on future loaded modules")
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> Cc: stable@vger.kernel.org

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
> kernel/trace/trace_fprobe.c | 13 +++++++++++++
> kernel/trace/trace_probe.h | 1 +
> 2 files changed, 14 insertions(+)