The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
	michael.christie@oracle.com, sgarzare@redhat.com,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [PATCH v7 1/8] vhost: Add a new parameter in vhost_dev to allow user select kthread
Date: Sun,  2 Mar 2025 22:32:03 +0800	[thread overview]
Message-ID: <20250302143259.1221569-2-lulu@redhat.com> (raw)
In-Reply-To: <20250302143259.1221569-1-lulu@redhat.com>

The vhost now uses vhost_task and workers as a child of the owner thread.
While this aligns with containerization principles,it confuses some legacy
userspace app, Therefore, we are reintroducing kthread API support.

Introduce a new parameter to enable users to choose between
kthread and task mode.

Signed-off-by: Cindy Lu <lulu@redhat.com>
---
 drivers/vhost/vhost.c | 1 +
 drivers/vhost/vhost.h | 9 +++++++++
 2 files changed, 10 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 63612faeab72..250dc43f1786 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -552,6 +552,7 @@ void vhost_dev_init(struct vhost_dev *dev,
 	dev->byte_weight = byte_weight;
 	dev->use_worker = use_worker;
 	dev->msg_handler = msg_handler;
+	dev->inherit_owner = true;
 	init_waitqueue_head(&dev->wait);
 	INIT_LIST_HEAD(&dev->read_list);
 	INIT_LIST_HEAD(&dev->pending_list);
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index bb75a292d50c..19bb94922a0e 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -176,6 +176,15 @@ struct vhost_dev {
 	int byte_weight;
 	struct xarray worker_xa;
 	bool use_worker;
+	/*
+	 * If inherit_owner is true we use vhost_tasks to create
+	 * the worker so all settings/limits like cgroups, NPROC,
+	 * scheduler, etc are inherited from the owner. If false,
+	 * we use kthreads and only attach to the same cgroups
+	 * as the owner for compat with older kernels.
+	 * here we use true as default value
+	 */
+	bool inherit_owner;
 	int (*msg_handler)(struct vhost_dev *dev, u32 asid,
 			   struct vhost_iotlb_msg *msg);
 };
-- 
2.45.0


  reply	other threads:[~2025-03-02 14:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-02 14:32 [PATCH v7 0/8] vhost: Add support of kthread API Cindy Lu
2025-03-02 14:32 ` Cindy Lu [this message]
2025-03-02 14:32 ` [PATCH v7 2/8] vhost: Reintroduce vhost_worker to support kthread Cindy Lu
2025-03-02 14:32 ` [PATCH v7 3/8] vhost: Add the cgroup related function Cindy Lu
2025-03-02 14:32 ` [PATCH v7 4/8] vhost: Introduce vhost_worker_ops in vhost_worker Cindy Lu
2025-03-02 14:32 ` [PATCH v7 5/8] vhost: Reintroduce kthread mode support in vhost Cindy Lu
2025-03-02 14:32 ` [PATCH v7 6/8] vhost: uapi to control task mode (owner vs kthread) Cindy Lu
2025-03-03  8:58   ` Stefano Garzarella
2025-03-28  5:43     ` Cindy Lu
2025-03-02 14:32 ` [PATCH v7 7/8] vhost: Add check for inherit_owner status Cindy Lu
2025-03-02 14:32 ` [PATCH v7 8/8] vhost: Add a KConfig knob to enable IOCTL VHOST_FORK_FROM_OWNER Cindy Lu
2025-03-03  5:52   ` Jason Wang
2025-03-03  9:12     ` Stefano Garzarella
2025-03-28  5:47       ` Cindy Lu
2025-03-03 17:33     ` Michael S. Tsirkin
2025-03-10  4:54       ` Jason Wang
2025-03-20  9:38         ` Cindy Lu
2025-03-28  8:24       ` Cindy Lu
2025-03-21 19:39     ` Michael S. Tsirkin
2025-03-03  4:25 ` [PATCH v7 0/8] vhost: Add support of kthread API Lei Yang
2025-03-21 19:36 ` Michael S. Tsirkin
2025-03-28  5:43   ` Cindy Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250302143259.1221569-2-lulu@redhat.com \
    --to=lulu@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox