[tip: x86/asm] x86/irq/32: Change some static functions to bool

tip-bot2 for Uros Bizjak
2025-03-04T10:36:23Z

Commit-ID: 7b52de3a2811bf16f52b895478920113e1b39878
Gitweb: https://git.kernel.org/tip/7b52de3a2811bf16f52b895478920113e1b39878
Author: Uros Bizjak <ubizjak@gmail.com>
AuthorDate: Mon, 03 Mar 2025 16:54:25 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 04 Mar 2025 11:21:40 +01:00

x86/irq/32: Change some static functions to bool

The return values of these functions is 0/1, but they use an int
type instead of bool:

check_stack_overflow()
execute_on_irq_stack()

Change the type of these function to bool and adjust their return
values and affected helper variables.

[ mingo: Rewrote the changelog ]

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250303155446.112769-5-ubizjak@gmail.com
---
arch/x86/kernel/irq_32.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index 2428d66..566a93d 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -29,7 +29,7 @@
int sysctl_panic_on_stackoverflow __read_mostly;

/* Debugging check for stack overflow: is there less than 1KB free? */
-static int check_stack_overflow(void)
+static bool check_stack_overflow(void)
{
unsigned long sp = current_stack_pointer & (THREAD_SIZE - 1);

@@ -45,7 +45,7 @@ static void print_stack_overflow(void)
}

#else
-static inline int check_stack_overflow(void) { return 0; }
+static inline bool check_stack_overflow(void) { return false; }
static inline void print_stack_overflow(void) { }
#endif

@@ -65,7 +65,7 @@ static inline void *current_stack(void)
return (void *)(current_stack_pointer & ~(THREAD_SIZE - 1));
}

-static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
+static inline bool execute_on_irq_stack(bool overflow, struct irq_desc *desc)
{
struct irq_stack *curstk, *irqstk;
u32 *isp, *prev_esp;
@@ -80,7 +80,7 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
* current stack (which is the irq stack already after all)
*/
if (unlikely(curstk == irqstk))
- return 0;
+ return false;

isp = (u32 *) ((char *)irqstk + sizeof(*irqstk));

@@ -98,7 +98,7 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
: [thunk_target] "D" (desc->handle_irq)
COMMA(ASM_CALL_CONSTRAINT)
: "memory", "cc", "edx", "ecx");
- return 1;
+ return true;
}

/*
@@ -147,7 +147,7 @@ void do_softirq_own_stack(void)

void __handle_irq(struct irq_desc *desc, struct pt_regs *regs)
{
- int overflow = check_stack_overflow();
+ bool overflow = check_stack_overflow();

if (user_mode(regs) || !execute_on_irq_stack(overflow, desc)) {
if (unlikely(overflow))