public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Uros Bizjak <ubizjak@gmail.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Uros Bizjak <ubizjak@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH -tip 3/5] x86/irq/32: Add ASM_CALL_CONSTRAINT to inline asm using CALL_NOSPEC
Date: Mon,  3 Mar 2025 16:54:23 +0100	[thread overview]
Message-ID: <20250303155446.112769-3-ubizjak@gmail.com> (raw)
In-Reply-To: <20250303155446.112769-1-ubizjak@gmail.com>

This constraint should be used for any inline asm which has a CALL
instruction, otherwise the compiler may schedule the asm before the
frame pointer gets set up by the containing function, causing objtool
to print a "call without frame pointer save/setup" warning.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
 arch/x86/kernel/irq_32.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index eab458009f97..f351fa1ee6a7 100644
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -59,6 +59,7 @@ static void call_on_stack(void *func, void *stack)
 		     "movl %[sp], %%esp"
 		     : [sp] "+b" (stack)
 		     : [thunk_target] "D" (func)
+		       COMMA(ASM_CALL_CONSTRAINT)
 		     : "memory", "cc", "edx", "ecx", "eax");
 }
 
@@ -98,6 +99,7 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
 		     "movl %[sp], %%esp"
 		     : "+a" (desc), [sp] "+b" (isp)
 		     : [thunk_target] "D" (desc->handle_irq)
+		       COMMA(ASM_CALL_CONSTRAINT)
 		     : "memory", "cc", "edx", "ecx");
 	return 1;
 }
-- 
2.42.0


  parent reply	other threads:[~2025-03-03 15:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 15:54 [PATCH -tip 1/5] x86/irq/32: Use named operands in inline asm Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 2/5] x86/irq/32: Add missing clobber to " Uros Bizjak
2025-03-04 10:06   ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36   ` tip-bot2 for Uros Bizjak
2025-03-04 19:23   ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` Uros Bizjak [this message]
2025-03-04 10:06   ` [tip: x86/asm] x86/irq/32: Add ASM_CALL_CONSTRAINT to inline asm using CALL_NOSPEC tip-bot2 for Uros Bizjak
2025-03-04 10:36   ` tip-bot2 for Uros Bizjak
2025-03-04 19:23   ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 4/5] x86/irq/32: Use current_stack_pointer to avoid asm() in check_stack_overflow() Uros Bizjak
2025-03-04 10:06   ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36   ` tip-bot2 for Uros Bizjak
2025-03-04 19:23   ` tip-bot2 for Uros Bizjak
2025-03-04 19:33   ` tip-bot2 for Uros Bizjak
2025-03-03 15:54 ` [PATCH -tip 5/5] x86/irq/32: Change some static functions to bool Uros Bizjak
2025-03-04 10:06   ` [tip: x86/asm] " tip-bot2 for Uros Bizjak
2025-03-04 10:36   ` tip-bot2 for Uros Bizjak
2025-03-04 19:23   ` tip-bot2 for Uros Bizjak
2025-03-04 19:33   ` tip-bot2 for Uros Bizjak
2025-03-04 10:06 ` [tip: x86/asm] x86/irq/32: Use named operands in inline asm tip-bot2 for Uros Bizjak
2025-03-04 10:36 ` tip-bot2 for Uros Bizjak
2025-03-04 19:23 ` tip-bot2 for Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250303155446.112769-3-ubizjak@gmail.com \
    --to=ubizjak@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox