[PATCH] staging: iio: ad5933: Fix CamelCase naming

[PATCH] staging: iio: ad5933: Fix CamelCase naming

[Saalim Quadri]

Reported by checkpatch:

CHECK: Avoid CamelCase

Signed-off-by: Saalim Quadri <danascape@gmail.com>
---
 drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index d5544fc2fe98..a1a5eee4f736 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -43,10 +43,10 @@
 #define AD5933_CTRL_POWER_DOWN		(0xA << 4)
 #define AD5933_CTRL_STANDBY		(0xB << 4)
 
-#define AD5933_CTRL_RANGE_2000mVpp	(0x0 << 1)
-#define AD5933_CTRL_RANGE_200mVpp	(0x1 << 1)
-#define AD5933_CTRL_RANGE_400mVpp	(0x2 << 1)
-#define AD5933_CTRL_RANGE_1000mVpp	(0x3 << 1)
+#define AD5933_CTRL_RANGE_2000MVPP	(0x0 << 1)
+#define AD5933_CTRL_RANGE_200MVPP	(0x1 << 1)
+#define AD5933_CTRL_RANGE_400MVPP	(0x2 << 1)
+#define AD5933_CTRL_RANGE_1000MVPP	(0x3 << 1)
 #define AD5933_CTRL_RANGE(x)		((x) << 1)
 
 #define AD5933_CTRL_PGA_GAIN_1		(0x1 << 0)
@@ -68,8 +68,8 @@
 #define AD5933_I2C_ADDR_POINTER		0xB0
 
 /* Device Specs */
-#define AD5933_INT_OSC_FREQ_Hz		16776000
-#define AD5933_MAX_OUTPUT_FREQ_Hz	100000
+#define AD5933_INT_OSC_FREQ_HZ		16776000
+#define AD5933_MAX_OUTPUT_FREQ_HZ	100000
 #define AD5933_MAX_RETRIES		100
 
 #define AD5933_OUT_RANGE		1
@@ -302,7 +302,7 @@ static ssize_t ad5933_store_frequency(struct device *dev,
 	if (ret)
 		return ret;
 
-	if (val > AD5933_MAX_OUTPUT_FREQ_Hz)
+	if (val > AD5933_MAX_OUTPUT_FREQ_HZ)
 		return -EINVAL;
 
 	ret = iio_device_claim_direct_mode(indio_dev);
@@ -695,7 +695,7 @@ static int ad5933_probe(struct i2c_client *client)
 		st->mclk_hz = ext_clk_hz;
 		st->ctrl_lb = AD5933_CTRL_EXT_SYSCLK;
 	} else {
-		st->mclk_hz = AD5933_INT_OSC_FREQ_Hz;
+		st->mclk_hz = AD5933_INT_OSC_FREQ_HZ;
 		st->ctrl_lb = AD5933_CTRL_INT_SYSCLK;
 	}
 
-- 
2.34.1

Re: [PATCH] staging: iio: ad5933: Fix CamelCase naming

[Greg KH]

On Mon, Mar 03, 2025 at 06:22:46PM +0530, Saalim Quadri wrote:
> Reported by checkpatch:
> 
> CHECK: Avoid CamelCase
> 
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index d5544fc2fe98..a1a5eee4f736 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -43,10 +43,10 @@
>  #define AD5933_CTRL_POWER_DOWN		(0xA << 4)
>  #define AD5933_CTRL_STANDBY		(0xB << 4)
>  
> -#define AD5933_CTRL_RANGE_2000mVpp	(0x0 << 1)
> -#define AD5933_CTRL_RANGE_200mVpp	(0x1 << 1)
> -#define AD5933_CTRL_RANGE_400mVpp	(0x2 << 1)
> -#define AD5933_CTRL_RANGE_1000mVpp	(0x3 << 1)
> +#define AD5933_CTRL_RANGE_2000MVPP	(0x0 << 1)
> +#define AD5933_CTRL_RANGE_200MVPP	(0x1 << 1)
> +#define AD5933_CTRL_RANGE_400MVPP	(0x2 << 1)
> +#define AD5933_CTRL_RANGE_1000MVPP	(0x3 << 1)

No, these are units of measurement, the "m" is correct here, right?  If
you change that to "M" it logically means something a lot different :(

Please always treat checkpatch.pl as a hint, not as a rule.

thanks,

greg k-h

Re: [PATCH] staging: iio: ad5933: Fix CamelCase naming

[Saalim Quadri]

I am so sorry for such a silly mistake,
will try to read before sending patches from now on :/

Yours Sincerely,
Saalim Quadri