From: Changwoo Min <changwoo@igalia.com>
To: tj@kernel.org, void@manifault.com, arighi@nvidia.com
Cc: kernel-dev@igalia.com, linux-kernel@vger.kernel.org,
Changwoo Min <changwoo@igalia.com>
Subject: [PATCH v3 1/2] sched_ext: Change the event type from u64 to s64
Date: Tue, 4 Mar 2025 10:27:39 +0900 [thread overview]
Message-ID: <20250304012740.35473-2-changwoo@igalia.com> (raw)
In-Reply-To: <20250304012740.35473-1-changwoo@igalia.com>
The event count could be negative in the future,
so change the event type from u64 to s64.
Signed-off-by: Changwoo Min <changwoo@igalia.com>
---
kernel/sched/ext.c | 20 ++++++++++----------
tools/sched_ext/scx_qmap.bpf.c | 16 ++++++++--------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index 986b655911df..686629a860f3 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -1489,53 +1489,53 @@ struct scx_event_stats {
* If ops.select_cpu() returns a CPU which can't be used by the task,
* the core scheduler code silently picks a fallback CPU.
*/
- u64 SCX_EV_SELECT_CPU_FALLBACK;
+ s64 SCX_EV_SELECT_CPU_FALLBACK;
/*
* When dispatching to a local DSQ, the CPU may have gone offline in
* the meantime. In this case, the task is bounced to the global DSQ.
*/
- u64 SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE;
+ s64 SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE;
/*
* If SCX_OPS_ENQ_LAST is not set, the number of times that a task
* continued to run because there were no other tasks on the CPU.
*/
- u64 SCX_EV_DISPATCH_KEEP_LAST;
+ s64 SCX_EV_DISPATCH_KEEP_LAST;
/*
* If SCX_OPS_ENQ_EXITING is not set, the number of times that a task
* is dispatched to a local DSQ when exiting.
*/
- u64 SCX_EV_ENQ_SKIP_EXITING;
+ s64 SCX_EV_ENQ_SKIP_EXITING;
/*
* If SCX_OPS_ENQ_MIGRATION_DISABLED is not set, the number of times a
* migration disabled task skips ops.enqueue() and is dispatched to its
* local DSQ.
*/
- u64 SCX_EV_ENQ_SKIP_MIGRATION_DISABLED;
+ s64 SCX_EV_ENQ_SKIP_MIGRATION_DISABLED;
/*
* The total number of tasks enqueued (or pick_task-ed) with a
* default time slice (SCX_SLICE_DFL).
*/
- u64 SCX_EV_ENQ_SLICE_DFL;
+ s64 SCX_EV_ENQ_SLICE_DFL;
/*
* The total duration of bypass modes in nanoseconds.
*/
- u64 SCX_EV_BYPASS_DURATION;
+ s64 SCX_EV_BYPASS_DURATION;
/*
* The number of tasks dispatched in the bypassing mode.
*/
- u64 SCX_EV_BYPASS_DISPATCH;
+ s64 SCX_EV_BYPASS_DISPATCH;
/*
* The number of times the bypassing mode has been activated.
*/
- u64 SCX_EV_BYPASS_ACTIVATE;
+ s64 SCX_EV_BYPASS_ACTIVATE;
};
/*
@@ -1584,7 +1584,7 @@ static DEFINE_PER_CPU(struct scx_event_stats, event_stats_cpu);
* @kind: a kind of event to dump
*/
#define scx_dump_event(s, events, kind) do { \
- dump_line(&(s), "%40s: %16llu", #kind, (events)->kind); \
+ dump_line(&(s), "%40s: %16lld", #kind, (events)->kind); \
} while (0)
diff --git a/tools/sched_ext/scx_qmap.bpf.c b/tools/sched_ext/scx_qmap.bpf.c
index 45fd643d2ca0..26c40ca4f36c 100644
--- a/tools/sched_ext/scx_qmap.bpf.c
+++ b/tools/sched_ext/scx_qmap.bpf.c
@@ -776,21 +776,21 @@ static int monitor_timerfn(void *map, int *key, struct bpf_timer *timer)
__COMPAT_scx_bpf_events(&events, sizeof(events));
- bpf_printk("%35s: %llu", "SCX_EV_SELECT_CPU_FALLBACK",
+ bpf_printk("%35s: %lld", "SCX_EV_SELECT_CPU_FALLBACK",
scx_read_event(&events, SCX_EV_SELECT_CPU_FALLBACK));
- bpf_printk("%35s: %llu", "SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE",
+ bpf_printk("%35s: %lld", "SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE",
scx_read_event(&events, SCX_EV_DISPATCH_LOCAL_DSQ_OFFLINE));
- bpf_printk("%35s: %llu", "SCX_EV_DISPATCH_KEEP_LAST",
+ bpf_printk("%35s: %lld", "SCX_EV_DISPATCH_KEEP_LAST",
scx_read_event(&events, SCX_EV_DISPATCH_KEEP_LAST));
- bpf_printk("%35s: %llu", "SCX_EV_ENQ_SKIP_EXITING",
+ bpf_printk("%35s: %lld", "SCX_EV_ENQ_SKIP_EXITING",
scx_read_event(&events, SCX_EV_ENQ_SKIP_EXITING));
- bpf_printk("%35s: %llu", "SCX_EV_ENQ_SLICE_DFL",
+ bpf_printk("%35s: %lld", "SCX_EV_ENQ_SLICE_DFL",
scx_read_event(&events, SCX_EV_ENQ_SLICE_DFL));
- bpf_printk("%35s: %llu", "SCX_EV_BYPASS_DURATION",
+ bpf_printk("%35s: %lld", "SCX_EV_BYPASS_DURATION",
scx_read_event(&events, SCX_EV_BYPASS_DURATION));
- bpf_printk("%35s: %llu", "SCX_EV_BYPASS_DISPATCH",
+ bpf_printk("%35s: %lld", "SCX_EV_BYPASS_DISPATCH",
scx_read_event(&events, SCX_EV_BYPASS_DISPATCH));
- bpf_printk("%35s: %llu", "SCX_EV_BYPASS_ACTIVATE",
+ bpf_printk("%35s: %lld", "SCX_EV_BYPASS_ACTIVATE",
scx_read_event(&events, SCX_EV_BYPASS_ACTIVATE));
bpf_timer_start(timer, ONE_SEC_IN_NS, 0);
--
2.48.1
next prev parent reply other threads:[~2025-03-04 1:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 1:27 [PATCH v3 0/2] sched_ext: Add trace point to sched_ext core events Changwoo Min
2025-03-04 1:27 ` Changwoo Min [this message]
2025-03-04 1:27 ` [PATCH v3 2/2] sched_ext: Add trace point to track " Changwoo Min
2025-03-04 6:41 ` Andrea Righi
2025-03-04 10:39 ` Changwoo Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304012740.35473-2-changwoo@igalia.com \
--to=changwoo@igalia.com \
--cc=arighi@nvidia.com \
--cc=kernel-dev@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox