From: Boris Brezillon <boris.brezillon@collabora.com>
To: Ashley Smith <ashley.smith@collabora.com>
Cc: Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Heiko Stuebner <heiko@sntech.de>,
kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values
Date: Tue, 4 Mar 2025 09:11:41 +0100 [thread overview]
Message-ID: <20250304091141.50f21736@collabora.com> (raw)
In-Reply-To: <20250303180444.3768993-1-ashley.smith@collabora.com>
On Mon, 3 Mar 2025 18:04:32 +0000
Ashley Smith <ashley.smith@collabora.com> wrote:
> Values for SC_STATUS_BLOCKED_REASON_ are documented in the G610 "Odin"
> GPU specification (CS_STATUS_BLOCKED_REASON register).
>
> This change updates the defines to the correct values.
>
> Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block")
> Signed-off-by: Ashley Smith <ashley.smith@collabora.com>
Adding my
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
back, so whoever ends up applying this patch doesn't have to add it
manually.
> ---
> Changes in v2:
> - Rename _RES to _RESOURCE
> ---
> drivers/gpu/drm/panthor/panthor_fw.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.h b/drivers/gpu/drm/panthor/panthor_fw.h
> index 22448abde992..6598d96c6d2a 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.h
> +++ b/drivers/gpu/drm/panthor/panthor_fw.h
> @@ -102,9 +102,9 @@ struct panthor_fw_cs_output_iface {
> #define CS_STATUS_BLOCKED_REASON_SB_WAIT 1
> #define CS_STATUS_BLOCKED_REASON_PROGRESS_WAIT 2
> #define CS_STATUS_BLOCKED_REASON_SYNC_WAIT 3
> -#define CS_STATUS_BLOCKED_REASON_DEFERRED 5
> -#define CS_STATUS_BLOCKED_REASON_RES 6
> -#define CS_STATUS_BLOCKED_REASON_FLUSH 7
> +#define CS_STATUS_BLOCKED_REASON_DEFERRED 4
> +#define CS_STATUS_BLOCKED_REASON_RESOURCE 5
> +#define CS_STATUS_BLOCKED_REASON_FLUSH 6
> #define CS_STATUS_BLOCKED_REASON_MASK GENMASK(3, 0)
> u32 status_blocked_reason;
> u32 status_wait_sync_value_hi;
>
> base-commit: 16e57a72780931c3c70dbc928aeee4a0518075de
next prev parent reply other threads:[~2025-03-04 8:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 18:04 [PATCH v2] drm/panthor: Update CS_STATUS_ defines to correct values Ashley Smith
2025-03-03 18:56 ` Liviu Dudau
2025-03-03 19:56 ` Adrian Larumbe
2025-03-04 8:11 ` Boris Brezillon [this message]
2025-03-05 10:42 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304091141.50f21736@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=ashley.smith@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox