Re: [PATCH 1/9] drivers/perf: hisi: Extend struct hisi_pmu_dev_info

Will Deacon
2025-03-01T06:23:49Z

On Tue, Feb 18, 2025 at 05:19:52PM +0800, Yicong Yang wrote:
> From: Junhao He <hejunhao3@huawei.com>
>
> The counter bits and event range may differ from versions of a
> certain uncore PMU. Make this device specific information into
> struct hisi_pmu_dev_info. This will help to simplify the
> initialization process by using a list of struct hisi_pmu_dev_info
> rather than checking the version.
>
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> drivers/perf/hisilicon/hisi_uncore_pmu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/perf/hisilicon/hisi_uncore_pmu.h b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> index f4fed2544877..777675838b80 100644
> --- a/drivers/perf/hisilicon/hisi_uncore_pmu.h
> +++ b/drivers/perf/hisilicon/hisi_uncore_pmu.h
> @@ -72,6 +72,8 @@ struct hisi_uncore_ops {
> struct hisi_pmu_dev_info {
> const char *name;
> const struct attribute_group **attr_groups;
> + u32 counter_bits;
> + u32 check_event;
> void *private;
> };

This doesn't really do anything on its own; please just fold it into the
patch where the new fields are used.

Will