Re: [PATCH 2/9] drivers/perf: hisi: Simplify the probe process for each DDRC version

Jonathan Cameron
2025-03-04T09:26:59Z

On Tue, 18 Feb 2025 17:19:53 +0800
Yicong Yang <yangyicong@huawei.com> wrote:

> From: Junhao He <hejunhao3@huawei.com>
>
> Version 1 and 2 of DDRC PMU also use different HID. Make use of
> struct acpi_device_id::driver_data for version specific information
> rather than judge the version register. This will help to
> simplify the probe process and also a bit easier for extension.
>
> Signed-off-by: Junhao He <hejunhao3@huawei.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Looks good to me. Looking at this I can see the check_reg naming
is an existing thing so maybe leave that alone for now and consider
renaming as a future improvement in readability.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>