From: Gaston Gonzalez <gascoar@gmail.com>
To: linux-staging@lists.linux.dev
Cc: dpenkler@gmail.com, gregkh@linuxfoundation.org,
dan.carpenter@linaro.org, arnd@arndb.de,
niharchaithanya@gmail.com, jiapeng.chong@linux.alibaba.com,
linux-kernel@vger.kernel.org, Gaston Gonzalez <gascoar@gmail.com>
Subject: [PATCH 3/4] staging: gpib: fix kernel-doc section for usb_gpib_line_status() function
Date: Tue, 4 Mar 2025 16:25:41 -0300 [thread overview]
Message-ID: <20250304192603.40565-7-gascoar@gmail.com> (raw)
In-Reply-To: <20250304192603.40565-1-gascoar@gmail.com>
The function name field in the kernel-doc section for the
usb_gpib_line_status() is defined as 'line_status'. In addition, after
the kernel-doc section, there are three macro definition instead of the
function definition.
These issues trigger the warning:
warning: expecting prototype for line_status(). Prototype was for WQT()
instead.
Fix the warning by renaming the function in the kernel-doc section and
by moving the macros at the beginning of the file with the rest of
macros definition.
Signed-off-by: Gaston Gonzalez <gascoar@gmail.com>
---
drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
index 090857824d07..f7dd0809b06c 100644
--- a/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
+++ b/drivers/staging/gpib/lpvo_usb_gpib/lpvo_usb_gpib.c
@@ -78,6 +78,10 @@ module_param(debug, int, 0644);
dev_dbg(board->gpib_dev, format, ## __VA_ARGS__); } \
while (0)
+#define WQT wait_queue_entry_t
+#define WQH head
+#define WQE entry
+
/* standard and extended command sets of the usb-gpib adapter */
#define USB_GPIB_ON "\nIB\n"
@@ -131,6 +135,7 @@ module_param(debug, int, 0644);
#define INBUF_SIZE 128
+
struct char_buf { /* used by one_char() routine */
char *inbuf;
int last;
@@ -644,17 +649,12 @@ static void usb_gpib_interface_clear(gpib_board_t *board, int assert)
}
/**
- * line_status() - Read the status of the bus lines.
+ * usb_gpib_line_status() - Read the status of the bus lines.
*
* @board: the gpib_board data area for this gpib interface
*
* We can read all lines.
*/
-
-#define WQT wait_queue_entry_t
-#define WQH head
-#define WQE entry
-
static int usb_gpib_line_status(const gpib_board_t *board)
{
int buffer;
--
2.49.0.rc0
next prev parent reply other threads:[~2025-03-04 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 19:25 [PATCH 0/4] staging: gpib: some cleanups in lpvo_usb_gpib.c Gaston Gonzalez
2025-03-04 19:25 ` [PATCH 1/4] staging: gpib: fix kernel-doc section for write_loop() function Gaston Gonzalez
2025-03-04 19:25 ` [PATCH 2/4] staging: gpib: fix kernel-doc section for function usb_gpib_interface_clear() Gaston Gonzalez
2025-03-04 19:25 ` Gaston Gonzalez [this message]
2025-03-04 19:33 ` [PATCH 3/4] staging: gpib: fix kernel-doc section for usb_gpib_line_status() function Gaston Gonzalez
2025-03-04 19:25 ` [PATCH 4/4] staging: gpib: remove commented-out lines Gaston Gonzalez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250304192603.40565-7-gascoar@gmail.com \
--to=gascoar@gmail.com \
--cc=arnd@arndb.de \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=niharchaithanya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox