From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26F812905; Tue, 4 Mar 2025 05:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741066273; cv=none; b=JV8pbHwo7zRKGoq5MBLCQ5Y3Cn7we5xsQsbEvqjsoqk92F7X++SI1nyM/LCYfuuZSdKiAJHp1wHAR1KSzuDAO8ZR2PFnfuucqm87nZa/CNBo8CnzL843l/MSEEEIR/UPw4T+4xRkHMG3QfJe8SAdxYJCEtIg97QZ60cnJfYpp6c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741066273; c=relaxed/simple; bh=XOlyYoS+DYZzzpqMtqdefvheJDjjcKhfo/KUx+jL+mk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lFxBYMjQ9T+MOAdGThUr7ypw/TL1Pb51CEKtUu6LeMB/2iwwO/ju+42FmueS85dukfZ+HkvBdcCH0q40i6JaEI0/Xpsu5C/vO1ihr1eTamxyECyIkkI2H9ZG4CTZRYg06CIiiQ4bBuFyRckklRCwsb4OfUQS8+RMKTs32jmBIxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LAqEY2Bm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LAqEY2Bm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 082D6C4CEE5; Tue, 4 Mar 2025 05:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741066272; bh=XOlyYoS+DYZzzpqMtqdefvheJDjjcKhfo/KUx+jL+mk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LAqEY2BmguNwPwzhfQ48ubVXpbewXHohiWkbtc1CivNRjq0lKKTbdjZ2bycuuVsKi NDGnJ6lYzINGjiiQ95PE+ZZXQ8Q8+NNZKXNqiwIBbo1k6cLp0Gp9xyBGHwzBy4DpzF ZPEF3pPw0hOB2zNhjomd98mFvfybgkAx+3RqGAo0= Date: Tue, 4 Mar 2025 06:30:46 +0100 From: Greg KH To: Zi Yan Cc: Liu Shixin , Baolin Wang , linux-mm@kvack.org, Andrew Morton , Barry Song , David Hildenbrand , Kefeng Wang , Lance Yang , Ryan Roberts , Matthew Wilcox , Hugh Dickins , Charan Teja Kalla , linux-kernel@vger.kernel.org, Shivank Garg , stable@vger.kernel.org Subject: Re: [PATCH v2] mm/migrate: fix shmem xarray update during migration Message-ID: <2025030437-posting-barbecue-94af@gregkh> References: <20250228174953.2222831-1-ziy@nvidia.com> <16838F71-3E96-4EFE-BDA1-600C33F75D36@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16838F71-3E96-4EFE-BDA1-600C33F75D36@nvidia.com> On Mon, Mar 03, 2025 at 09:03:04PM -0500, Zi Yan wrote: > On 28 Feb 2025, at 12:49, Zi Yan wrote: > > > Pagecache uses multi-index entries for large folio, so does shmem. Only > > swap cache still stores multiple entries for a single large folio. > > Commit fc346d0a70a1 ("mm: migrate high-order folios in swap cache correctly") > > fixed swap cache but got shmem wrong by storing multiple entries for > > a large shmem folio. Fix it by storing a single entry for a shmem > > folio. > > > > Fixes: fc346d0a70a1 ("mm: migrate high-order folios in swap cache correctly") > > Reported-by: Liu Shixin > > Closes: https://lore.kernel.org/all/28546fb4-5210-bf75-16d6-43e1f8646080@huawei.com/ > > Signed-off-by: Zi Yan > > Reviewed-by: Shivank Garg > > +Cc:stable > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.