From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B2FF2040A9 for ; Wed, 5 Mar 2025 09:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741166941; cv=none; b=mluFf9G/PQ1awnsDq46eHf7xmPb5XO+oJTN9DL5AWteeLiNuMFRkdORbUW59YwpnLq7v4aZ8ZB+gz1nw5FP0vrdijAeVZHZSsyLHdtpRwGgftqnUB8GjX9Psrm6YMZpT04EdyP9aSXMsMULaYFDlNRVRgpv0cMRcRiYqf0hSRRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741166941; c=relaxed/simple; bh=3RyfPyCJa/tpuKGOY4+lgz/0CKbtUzXOOAWxjU4A/sc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GnSLNF1CvmaioD88286/VARA6YOp98+L5lIdITbGwzJf2v+8vGqvpksDMv/vjT0IUKS3D50ERyoI9lE50/VIkheobemUfVgS2fBezLImrx6D0eX4m/zm3+NDI5DnLbT9on/as7y61I117vm4J4GfIiD2zROyQgz6tOSk5fEL4jU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RdA0SmoI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RdA0SmoI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741166937; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FTeYQGmJeU97hLjZUQj6XASwjS9zaIwc0VW0y5NqZ+Y=; b=RdA0SmoI+lmJ6k9qVwdSfB5zXDPSUuEQOI3xCKUXnD/HzFfBoglCS2zCu45c2mZdMiDIjY 0yfO4dIfPVKgMCmuTRQ7Qv3olsvQoNHMVAqL9h8lD7Z6rzBrXWmxQwSLuYojxkHigM7Lr9 045dWP0SP9JR6ZE7XxiA0nx8koP3DCU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-351-qqsR5gmjOE2znfR4ZW3gKg-1; Wed, 05 Mar 2025 04:28:55 -0500 X-MC-Unique: qqsR5gmjOE2znfR4ZW3gKg-1 X-Mimecast-MFC-AGG-ID: qqsR5gmjOE2znfR4ZW3gKg_1741166934 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3911232fd8bso1850821f8f.3 for ; Wed, 05 Mar 2025 01:28:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741166934; x=1741771734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FTeYQGmJeU97hLjZUQj6XASwjS9zaIwc0VW0y5NqZ+Y=; b=Kx6V4802iPWGgCTN9fWerirtaxmileiLn9PjfbtfPUffqdfGwcBL8P03+QvfL8b2ts tGWkY8jr7X+/8ZKGqPv9JxIl/fTxzWh1PEI09SwAhsli6o6y/mbCqhp0rY3b/I/PTecS jKI6Mp+leR0zOXILWo3WUTUyyTszVILun2naxNceWjaBGnc+NPtZ6SQWBfg2UOkglt+2 7AtlnWhsHbh85kStj1c7fcW5nTR1rJzdGfrRgojCWYmuyLh+VgBOO2lHB6N7Xbfoel1T eqwWtZLdLaFFKLUa57ltiLhlwOSm0v0tec3qE9C+AoSYHDHH6y9U0SX7uJ04zuJnd7LM goBA== X-Forwarded-Encrypted: i=1; AJvYcCUEtzHVngvw2r76sRG1fbXa8wEQCtWb5qT8c8eRp2ccrHLkyg0JkSEgZA50T743MXQeMH4iCUL50ReJBpo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5VdLbaYHAt1rzbmcVI8HwmKmK9yIcNtMPZJ7JQM1RiDV9GOS9 Io2QZRrMkLbIaaT2LBHPFG1ucRJhkmhoBcmic8uICphc2Bhybu8zy6d5R172QR4Gzzqf7nM30tG 8gNJCGEHNCn2YmbEoYneBTnGl67JBLRBaLUwXHe63LPeDHB64n1268Nhh6o3Dig== X-Gm-Gg: ASbGncujKfkYxmTk1DTzrP6VBPgAd3bcJtH0t0ad5t14QZhku0WLrMmtrX8EXDhF1nD oduZgPPvzN8r+EUXfHjJKBM+ByV2zguQCgeYt2Hs4ExvMPz4ck/FHwSLOmm0UvCfFCpH7x8cIHW kykYWx82VFFs3UN6wM2YoUcG6LaYa99AMiNYAmelCvpSAvJM2+k6mFWpgWhgyofh43YKYSX961+ CX3dZxbRL/XWZh8m16Q876ZSOoEGIhUzVJvpFxXIZ4BQ8Hr8XISK8h6FtHorjx6PphKb+FozXp8 DT4W9fiKrw== X-Received: by 2002:a5d:64a2:0:b0:390:ee01:68fa with SMTP id ffacd0b85a97d-3911f741aa8mr1774260f8f.24.1741166934460; Wed, 05 Mar 2025 01:28:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFqbiZg1q9NO5z1obiHx6s5lNrsAIzRTkNZH2/z7S8MpItFePV0q3Z90uV+qtbX8GSklxWg6Q== X-Received: by 2002:a5d:64a2:0:b0:390:ee01:68fa with SMTP id ffacd0b85a97d-3911f741aa8mr1774238f8f.24.1741166934111; Wed, 05 Mar 2025 01:28:54 -0800 (PST) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bd42c5b33sm12002165e9.22.2025.03.05.01.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Mar 2025 01:28:53 -0800 (PST) Date: Wed, 5 Mar 2025 04:28:50 -0500 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: Jakub Kicinski , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jorgen Hansen , Jason Wang , kvm@vger.kernel.org, Stefan Hajnoczi , virtualization@lists.linux-foundation.org, linux-hyperv@vger.kernel.org, Dexuan Cui , Bobby Eshleman Subject: Re: [PATCH net-next 1/3] vsock: add network namespace support Message-ID: <20250305042757-mutt-send-email-mst@kernel.org> References: <20200116172428.311437-1-sgarzare@redhat.com> <20200116172428.311437-2-sgarzare@redhat.com> <20250305022900-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 05, 2025 at 10:23:08AM +0100, Stefano Garzarella wrote: > On Wed, 5 Mar 2025 at 08:32, Michael S. Tsirkin wrote: > > > > On Thu, Jan 16, 2020 at 06:24:26PM +0100, Stefano Garzarella wrote: > > > This patch adds a check of the "net" assigned to a socket during > > > the vsock_find_bound_socket() and vsock_find_connected_socket() > > > to support network namespace, allowing to share the same address > > > (cid, port) across different network namespaces. > > > > > > This patch adds 'netns' module param to enable this new feature > > > (disabled by default), because it changes vsock's behavior with > > > network namespaces and could break existing applications. > > > G2H transports will use the default network namepsace (init_net). > > > H2G transports can use different network namespace for different > > > VMs. > > > > > > I'm not sure I understand the usecase. Can you explain a bit more, > > please? > > It's been five years, but I'm trying! > We are tracking this RFE here [1]. > > I also add Jakub in the thread with who I discussed last year a possible > restart of this effort, he could add more use cases. > > The problem with vsock, host-side, currently is that if you launch a VM > with a virtio-vsock device (using vhost) inside a container (e.g., > Kata), so inside a network namespace, it is reachable from any other > container, whereas they would like some isolation. Also the CID is > shared among all, while they would like to reuse the same CID in > different namespaces. > > This has been partially solved with vhost-user-vsock, but it is > inconvenient to use sometimes because of the hybrid-vsock problem > (host-side vsock is remapped to AF_UNIX). > > Something from the cover letter of the series [2]: > > As we partially discussed in the multi-transport proposal, it could > be nice to support network namespace in vsock to reach the following > goals: > - isolate host applications from guest applications using the same ports > with CID_ANY > - assign the same CID of VMs running in different network namespaces > - partition VMs between VMMs or at finer granularity > > Thanks, > Stefano > > [1] https://gitlab.com/vsock/vsock/-/issues/2 > [2] https://lore.kernel.org/virtualization/20200116172428.311437-1-sgarzare@redhat.com/ Ok so, host side. I get it. And the problem with your patches is that they affect the guest side. Fix that, basically. -- MST