From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC27E1547E2; Wed, 5 Mar 2025 07:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741161457; cv=none; b=fU4GSsX8sn1Aw9lR4OqG6GV03B04krGnt8fxzZ/ZCSIwhCDfikU7wh+ySZmM+Q5kJi7pTUyPftwgoCqCQzs/nVwlQ2djxd4SgxUxfNJwulE2JHKINLC9NmnLXie/bjlhdAVFf1AsBXDU3qGCtYH11+fMRfJMIujgLThqRZN1bt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741161457; c=relaxed/simple; bh=1qfqTAY5g4rU5BKvohe/wSQnKZRFwIwUMMFb18lwqUU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Y2x/QL+6xxtCV8b9HJS/q6x8FSan1fJdxmHOzPJPIE8JuCwGloFQ5tiFhv2flKi7VLsz4Ra3UmX6DlPskJ1qf4HRHXpSN/k0unX7kiA1lajfJHI0vbc5f/bklw8I5Ns8+EbiEcMJsisYUQhyW1bqIp8GeHnUQKapu1XO3/Af2uU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MWpWHrmM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MWpWHrmM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E045C4CEE2; Wed, 5 Mar 2025 07:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1741161456; bh=1qfqTAY5g4rU5BKvohe/wSQnKZRFwIwUMMFb18lwqUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MWpWHrmM6FO5slFEe1awm0P61uonDdfX3ReUfsTLsL7J86m5wr+uuhUcH+qImGhCX SB46SjNYa6B1UYlZl6TrKQDxTT9vpRnYwNXt65iGD+vs1lRX5+4k8rilVsH1TF0Rn7 WnAmmnavwtnnrgNysNzXEnisr77zmZJ+hv5bcsX8= Date: Wed, 5 Mar 2025 08:57:33 +0100 From: Greg Kroah-Hartman To: "Usyskin, Alexander" Cc: Markus Elfring , "kernel-janitors@vger.kernel.org" , Arnd Bergmann , "cocci@inria.fr" , LKML Subject: Re: [v2] mei: Improve exception handling in mei_cl_irq_read_msg() Message-ID: <2025030508-iodize-diagram-3e0f@gregkh> References: <00589154-00ac-4ed5-2a37-60b3c6f6c523@web.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 05, 2025 at 07:41:25AM +0000, Usyskin, Alexander wrote: > > > > > > In general, why not, but the label naming is bad. > > > It hides the original intent to discard this message. > > > Let's rename existing label to discard_nocb: and leave a new one as discard:. > > > Also, the patch will be smaller in this way. > > > > Do you expect a third patch version according to your naming preferences? > > > > Regards, > > Markus > > I prefer to, as the current patch reduces this code readability. > > - - > Thanks, > Sasha > > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot