[PATCH v7 0/3] drm/sched: Documentation and refcount improvements

Philipp Stanner
2025-03-05T13:06:02Z

Changes in v7:
- Add Christian's info about violated dma_fence rules. (Christian)
- Fix some typos

Changes in v6:
- Switch patches 1 and 2. (Maira)
- Move section related to run_job() out of timedout_job() patch.
(Maira).
- Fix some places for correct crosslink references.
- Add comment to inform about run_job() incrementing the refcount.
(Danilo)

Changes in v5:
- Fix broken enumarated list in timedout_job's docu.
- Add TODO for documenting the dma_fence rules in timedout_job one
day.

Changes in v4:
- Remove mention of vague "dma_fence rules" in timedout_job() again
since I couldn't get input on what those rules precisely are.
- Address a forgotten TODO. (Me)
- Reposition "Return:" statements to make them congruent with the
official kernel style. (Tvrtko)
- Change formatting a bit because of crazy make htmldocs errors. (Me)

Changes in v3:
- timedout_job(): various docu wording improvements. (Danilo)
- Use the term "ring" consistently. (Danilo)
- Add fully fledged docu for enum drm_gpu_sched_stat. (Danilo)

Changes in v2:
- Document what run_job() is allowed to return. (Tvrtko)
- Delete confusing comment about putting the fence. (Danilo)
- Apply Danilo's RB to patch 1.
- Delete info about job recovery for entities in patch 3. (Danilo, me)
- Set the term "ring" as fix term for both HW rings and FW rings. A
ring shall always be the thingy on the CPU ;) (Danilo)
- Many (all) other comments improvements in patch 3. (Danilo)

This is as series succeeding my previous patch [1].

I recognized that we are still referring to a non-existing function and
a deprecated one in the callback docu. We should probably also point out
the important distinction between hardware and firmware schedulers more
cleanly.

Please give me feedback, especially on the RFC comments in patch3.

(This series still fires docu-build-warnings. I want to gather feedback
on the opion questions first and will solve them in v2.)

Thank you,
Philipp

[1] https://lore.kernel.org/all/20241220124515.93169-2-phasta@kernel.org/

Philipp Stanner (3):
drm/sched: Adjust outdated docu for run_job()
drm/sched: Document run_job() refcount hazard
drm/sched: Update timedout_job()'s documentation

drivers/gpu/drm/scheduler/sched_main.c | 9 +-
include/drm/gpu_scheduler.h | 112 +++++++++++++++++--------
2 files changed, 83 insertions(+), 38 deletions(-)

--
2.48.1