From: Christoph Hellwig <hch@lst.de>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>,
Caleb Sander Mateos <csander@purestorage.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nvme-tcp: fix signedness bug in nvme_tcp_init_connection()
Date: Wed, 5 Mar 2025 15:38:14 +0100 [thread overview]
Message-ID: <20250305143814.GA18852@lst.de> (raw)
In-Reply-To: <739d3443-61c4-4b69-866b-142efde59062@stanley.mountain>
On Wed, Mar 05, 2025 at 05:37:15PM +0300, Dan Carpenter wrote:
> > if (ret >= 0 && ret < sizeof(*icresp))
> > ret = -ECONNRESET;
> > if (ret < 0) {
> > ...
>
> Sure, I can do that.
>
> I don't love casts either. I normally have tried to write these as
> "if (ret < 0 || ret < sizeof(*icresp)) {" and people don't love that.
I can see why people don't like it as it's really counterintuitive.
These kinds of interfaces just suck given the type promotion rules
unfortunately.
prev parent reply other threads:[~2025-03-05 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 9:39 [PATCH] nvme-tcp: fix signedness bug in nvme_tcp_init_connection() Dan Carpenter
2025-02-28 16:19 ` Caleb Sander Mateos
2025-03-01 23:16 ` Sagi Grimberg
2025-03-03 18:43 ` Chaitanya Kulkarni
2025-03-05 14:25 ` Christoph Hellwig
2025-03-05 14:37 ` Dan Carpenter
2025-03-05 14:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305143814.GA18852@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=dan.carpenter@linaro.org \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox