From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 479121FAC52 for ; Thu, 6 Mar 2025 08:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741248830; cv=none; b=SDJJNtCoo/gYNcFvb1EAX1AqtvkC+leZcvFIPpCE6++t/siFOD4w51YV1pN1HwNiwmi6GBJQGsde7Pprd+cuf/UkhfBIRazeVOszFvxw1NWrR6OzMywqWFMbBdvfNEXetDYmE0QoD30nY3QR8KA7iRUfDd5wieCtfuRh/5RMtqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741248830; c=relaxed/simple; bh=RmZfOZv9mSU7muKmuICqF7kMncNlxjNLjpCX8r/rE20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZaJoF5ezyX4L4Ms4itXhGZ9Ab4f/G9p9aL8L+aFEhnyn26jvlSBIg9un4uJieOQP2Tx8Ig2ZzwD9Z0bZ3ow9ppyu6ZQb3pnq5i4uTT4lfcnbAsbXhUikU8I+TRKjoIT4tID8b8bZB0T+X8pZkQUlMEYJlOQWDujA+9OrRPyB4Wk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=ZU6l3dcK; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="ZU6l3dcK" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-43bdc607c3fso1794005e9.3 for ; Thu, 06 Mar 2025 00:13:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1741248825; x=1741853625; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gLj5XWg7CIE0WfrqZc/tm6IHxyhmUxBPEQxl5xJpjbY=; b=ZU6l3dcKui5HpnluuvhRRRr6ihSgUF+VqdR0xI0uWtKO63tVKVIP2EozrAMrYmJw7l ugb1AHDTobNPgsPSC3x/sJE5euc+MjbK4GH8NPq8BubRCcDhLr/GvodttT4tbNSncbz8 iVamZgHbBS6yBpKk+cv0CMpOUA1QZLZ5OHrahrstxITZyCEtSnPvILnH4V6OsxPY1CVH T+K8ButUBRnuxpovbVeHcWLxuLJZ8lcbE51jHDm3qxsOdJTnxOjOxaCBzHrIQRwFWm4u cViGZqp/5Ieu3WbcpzYxmbUPuDoAxU4E51aIy/ACNR+Y16pUXoBKQegB0icyLdijUJMX 4TNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741248825; x=1741853625; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gLj5XWg7CIE0WfrqZc/tm6IHxyhmUxBPEQxl5xJpjbY=; b=qxLb8S/yz0LA8Tf5PbxDoO0lIqJJkeQrupN1NAwkEsmBoLcSnwfjRPC6KW64ggpnwH WstuK8E3DPdq4fBN/MwIFcEOC6Px5cXyV0yLbAJwvpXcFjnxHhJ00F+jX8AYhsc0V0ez VHoQLUP+J+OmXkrp0z2VjCHZ/QOjU1F081ewvN0WkPMkuoP6AkZdSso3hQQqLSAnaJ9B ktJrEzrWDLdZGHxS+IoyhVqQ7Dr3ZcpPCHVgrEIn+p7IuF/pM4CuS6xfbGI7xDxlzQou 3CxOu0w7iaaX1gZJQRrC6PfwAeoBQ1fawfl7NsrI5pFqVTacSJyQomYr7BI0kFkQjgJR GxZg== X-Forwarded-Encrypted: i=1; AJvYcCXJxHWngmo2Hk08QdHpfuHuajDUL0lhKtnZvDcgrVmPGWWPVLKh7bh40p9Yx7WcvdYZXXucVNgsaI/7Ueg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9iuMO8m66HxwAyTmwjPzwy9iyT43ayuNatcPsuuJkljjclbzP yXMSZFGCcoHL/aeLYdObZtg8JDjMoQWA57FQyG1LylatW7cIpB8TBD6zFS1/ENg= X-Gm-Gg: ASbGncvnVkuRM2tl6uHp1BbNAx93L/BUNpH1lnehcLjpPu0mQ8z1OKRdMUSMieK2UlD zdL2Ale2zV5Fd639dLcyyI7tW9shDbgd5ymkdJDOoboQ81r0i+Vg+lSmUx8d1hCfcjEsFaklv6X kNf7QpymRYSE8dmpj1m7R4QemMM/bEvbFK49mPj52i1Jwj0JanNSptszvUkgvkxkRNrCXC1bGES 4FXFF4yhu1EJcs0m1kmjH252/2EduN7C/ySMte10QvS7D0IDxNGROGGnIgFqacfLOYQdJUdF3/N QzU24zDhxBuZJA6NNcSgZNxmsyrzP+/EJ4lUMEqoShW0TcWOy0/G7mL2HEWTe7QKsS/EXNk5Xw= = X-Google-Smtp-Source: AGHT+IEizEhonB9j6mrELEVT2fWpqMYrBXgXdwXsHsJznxRDUYEH+hFr9DD372KDSR8Qo+hFwnpfNA== X-Received: by 2002:a05:600c:198f:b0:43b:c309:da40 with SMTP id 5b1f17b1804b1-43bd294de7dmr48473505e9.4.1741248825382; Thu, 06 Mar 2025 00:13:45 -0800 (PST) Received: from localhost (cst2-173-28.cust.vodafone.cz. [31.30.173.28]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3912c019557sm1262734f8f.50.2025.03.06.00.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 00:13:44 -0800 (PST) Date: Thu, 6 Mar 2025 09:13:43 +0100 From: Andrew Jones To: Charlie Jenkins Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, cleger@rivosinc.com, alex@ghiti.fr, Anup Patel , corbet@lwn.net Subject: Re: [PATCH v3 0/8] riscv: Unaligned access speed probing fixes and skipping Message-ID: <20250306-3f25ee3d4686442bd215a0fa@orel> References: <20250304120014.143628-10-ajones@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Mar 05, 2025 at 02:48:58PM -0800, Charlie Jenkins wrote: > On Tue, Mar 04, 2025 at 01:00:15PM +0100, Andrew Jones wrote: > > The first six patches of this series are fixes and cleanups of the > > unaligned access speed probing code. The next patch introduces a > > kernel command line option that allows the probing to be skipped. > > This command line option is a different approach than Jesse's [1]. > > [1] takes a cpu-list for a particular speed, supporting heterogeneous > > platforms. With this approach, the kernel command line should only > > be used for homogeneous platforms. [1] also only allowed 'fast' and > > 'slow' to be selected. This parameter also supports 'unsupported', > > which could be useful for testing code paths gated on that. The final > > patch adds the documentation. > > Why constrain the command line option to homogeneous platforms? Based on feedback at the last Plumber's, we've decided not to go out of our way to support heterogeneous platforms unless they start to materialize. With that in mind, and the fact that heterogeneous platforms can use the probing mechanism instead of the command line, then I didn't think the cpu-list support was worth it yet. Also, we can introduce support for an optional [,] attribute later, since the definition of the parameters would stay the same for when the cpu-list attribute is absent. Indeed, even if I was to introduce the cpu-list support now, I would make it optional with the absence of it behaving as this patch series implements. Thanks, drew > > - Charlie > > > > > (I'd be happy to split the fixes from the new skip support if we want to > > discuss the skip support independently, but I want to base on the fixes > > and I'm not sure if patchwork supports Based-on: $MESSAGE_ID/$LORE_URL > > or not at the moment, so I'm just posting together for now in order to > > be able to check for my patchwork green lights!) > > > > [1] https://lore.kernel.org/linux-riscv/20240805173816.3722002-1-jesse@rivosinc.com/ > > > > Thanks, > > drew > > > > --- > > v3: > > - Fix compile when RISCV_PROBE_UNALIGNED_ACCESS is not selected > > > > v2: > > - Change to command line option from table > > > > > > Andrew Jones (8): > > riscv: Annotate unaligned access init functions > > riscv: Fix riscv_online_cpu_vec > > riscv: Fix check_unaligned_access_all_cpus > > riscv: Change check_unaligned_access_speed_all_cpus to void > > riscv: Fix set up of cpu hotplug callbacks > > riscv: Fix set up of vector cpu hotplug callback > > riscv: Add parameter for skipping access speed tests > > Documentation/kernel-parameters: Add riscv unaligned speed parameters > > > > .../admin-guide/kernel-parameters.txt | 16 ++ > > arch/riscv/include/asm/cpufeature.h | 4 +- > > arch/riscv/kernel/traps_misaligned.c | 14 +- > > arch/riscv/kernel/unaligned_access_speed.c | 237 +++++++++++------- > > 4 files changed, 168 insertions(+), 103 deletions(-) > > > > -- > > 2.48.1 > >