Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller

Heiko Stübner
2025-03-06T16:17:11Z

Am Donnerstag, 6. März 2025, 16:53:48 MEZ schrieb Dmitry Osipenko:
> On 3/6/25 16:06, Heiko Stübner wrote:
> > Hi Dmitry,
> >
> > Am Donnerstag, 6. März 2025, 08:28:40 MEZ schrieb Dmitry Osipenko:
> >> From: Shreeya Patel <shreeya.patel@collabora.com>
> >>
> >> Add device tree support for Synopsys DesignWare HDMI RX
> >> Controller.
> >>
> >> Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Co-developed-by: Dingxian Wen <shawn.wen@rock-chips.com>
> >> Signed-off-by: Dingxian Wen <shawn.wen@rock-chips.com>
> >> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> ---

> >> + hdmi_receiver: hdmi_receiver@fdee0000 {
> >> + compatible = "rockchip,rk3588-hdmirx-ctrler", "snps,dw-hdmi-rx";
> >> + reg = <0x0 0xfdee0000 0x0 0x6000>;
> >> + power-domains = <&power RK3588_PD_VO1>;
> >> + rockchip,grf = <&sys_grf>;
> >> + rockchip,vo1-grf = <&vo1_grf>;
> >> + interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH 0>,
> >> + <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH 0>,
> >> + <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH 0>;
> >> + interrupt-names = "cec", "hdmi", "dma";
> >> + clocks = <&cru ACLK_HDMIRX>,
> >> + <&cru CLK_HDMIRX_AUD>,
> >> + <&cru CLK_CR_PARA>,
> >> + <&cru PCLK_HDMIRX>,
> >> + <&cru CLK_HDMIRX_REF>,
> >> + <&cru PCLK_S_HDMIRX>,
> >> + <&cru HCLK_VO1>;
> >> + clock-names = "aclk",
> >> + "audio",
> >> + "cr_para",
> >> + "pclk",
> >> + "ref",
> >> + "hclk_s_hdmirx",
> >> + "hclk_vo1";
> >> + resets = <&cru SRST_A_HDMIRX>, <&cru SRST_P_HDMIRX>,
> >> + <&cru SRST_HDMIRX_REF>, <&cru SRST_A_HDMIRX_BIU>;
> >> + reset-names = "axi", "apb", "ref", "biu";
> >> + memory-region = <&hdmi_receiver_cma>;
> >> + pinctrl-0 = <&hdmim1_rx>;
> >> + pinctrl-names = "default";
> >
> > hmm, this might be better living in the board dts?
>
> HDMI RX controller is a part of the SoC, it's not specific to a
> particular board. If you meaning move it into rock5b.dts, then we
> definitely shouldn't do it. It's like moving PCIe controller node into a
> board DT :)

sorry, should've been clearer. I meant the pinctrl.
There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
board specific.

Can you check if "most" boards use the M1 variant?

Rationale being, that if we know that most boards use the same set of
pins, it's likely ok to just have the minority boards override it.

Heiko