Re: [PATCH v14 1/3] arm64: dts: rockchip: Add device tree support for HDMI RX Controller

Dmitry Osipenko
2025-03-06T16:25:31Z

On 3/6/25 19:16, Heiko Stübner wrote:
>>>> + pinctrl-0 = <&hdmim1_rx>;
>>>> + pinctrl-names = "default";
>>> hmm, this might be better living in the board dts?
>> HDMI RX controller is a part of the SoC, it's not specific to a
>> particular board. If you meaning move it into rock5b.dts, then we
>> definitely shouldn't do it. It's like moving PCIe controller node into a
>> board DT 🙂
> sorry, should've been clearer. I meant the pinctrl.
> There are two sets of pins hdmim0-rx and hdmim1-rx which one is used is
> board specific.
>
> Can you check if "most" boards use the M1 variant?
>
> Rationale being, that if we know that most boards use the same set of
> pins, it's likely ok to just have the minority boards override it.

Will check, thanks for the clarification!

--
Best regards,
Dmitry