From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Andrew Morton <akpm@linux-foundation.org>,
Feng Yang <yangfeng@kylinos.cn>
Subject: [for-next][PATCH 02/10] ring-buffer: Fix bytes_dropped calculation issue
Date: Thu, 06 Mar 2025 10:25:50 -0500 [thread overview]
Message-ID: <20250306152618.395640284@goodmis.org> (raw)
In-Reply-To: 20250306152548.763044302@goodmis.org
From: Feng Yang <yangfeng@kylinos.cn>
The calculation of bytes-dropped and bytes_dropped_nested is reversed.
Although it does not affect the final calculation of total_dropped,
it should still be modified.
Link: https://lore.kernel.org/20250223070106.6781-1-yangfeng59949@163.com
Fixes: 6c43e554a2a5 ("ring-buffer: Add ring buffer startup selftest")
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
kernel/trace/ring_buffer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index 87caf9d48edb..7b6bd1f3daf4 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -7446,9 +7446,9 @@ static __init int rb_write_something(struct rb_test_data *data, bool nested)
/* Ignore dropped events before test starts. */
if (started) {
if (nested)
- data->bytes_dropped += len;
- else
data->bytes_dropped_nested += len;
+ else
+ data->bytes_dropped += len;
}
return len;
}
--
2.47.2
next prev parent reply other threads:[~2025-03-06 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 15:25 [for-next][PATCH 00/10] ring-buffer: Updates for v6.15 Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 01/10] ring-buffer: Allow persistent ring buffers to be mmapped Steven Rostedt
2025-03-06 15:25 ` Steven Rostedt [this message]
2025-03-06 15:25 ` [for-next][PATCH 03/10] ring-buffer: Use kaslr address instead of text delta Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 04/10] ring-buffer: Add buffer meta data for persistent ring buffer Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 05/10] ring-buffer: Add ring_buffer_meta_scratch() Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 06/10] tracing: Have persistent trace instances save KASLR offset Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 07/10] module: Add module_for_each_mod() function Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 08/10] tracing: Have persistent trace instances save module addresses Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 09/10] tracing: Show module names and addresses of last boot Steven Rostedt
2025-03-06 15:25 ` [for-next][PATCH 10/10] tracing: Update modules to persistent instances when loaded Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306152618.395640284@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=yangfeng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox