Re: [PATCH 1/2] drm/bridge: imx8qxp-ldb: cleanup return value

Liu Ying
2025-03-07T06:41:06Z

On 03/07/2025, Luca Ceresoli wrote:
> 'ret' can only be 0 at this point, being preceded by a 'if (ret) return
> ret;'. So return 0 for clarity.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> index 7bce2305d676714cdec7ce085cb53b25ce42f8e7..bee1c6002d5f84dc33b6d5dc123726703baa427e 100644
> --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c
> @@ -665,7 +665,7 @@ static int imx8qxp_ldb_probe(struct platform_device *pdev)
>
> ldb_add_bridge_helper(ldb, &imx8qxp_ldb_bridge_funcs);
>
> - return ret;
> + return 0;

I guess this is not the only place across the kernel tree where this cleanup
could be done. So, maybe use some tools to cleanup them all?

> }
>
> static void imx8qxp_ldb_remove(struct platform_device *pdev)
>

--
Regards,
Liu Ying