Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative

Liu Ying
2025-03-07T06:33:54Z

On 03/07/2025, Frank Li wrote:
> On Thu, Mar 06, 2025 at 06:28:41PM +0100, Luca Ceresoli wrote:
>> This warning notifies a clock was set to an inaccurate value. Modify the
>> string to also show the clock name.
>>
>> While doing that also rewrap the entire function call.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>> ---
>> drivers/gpu/drm/bridge/fsl-ldb.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c
>> index 0fc8a14fd80062248a43b8b93272101a7ca6158a..c7c899a9644bb827845fb3fe96a9695d79a91474 100644
>> --- a/drivers/gpu/drm/bridge/fsl-ldb.c
>> +++ b/drivers/gpu/drm/bridge/fsl-ldb.c
>> @@ -181,9 +181,9 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge,
>>
>> configured_link_freq = clk_get_rate(fsl_ldb->clk);
>> if (configured_link_freq != requested_link_freq)
>> - dev_warn(fsl_ldb->dev, "Configured LDB clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n",
>> - configured_link_freq,
>> - requested_link_freq);
>> + dev_warn(fsl_ldb->dev,
>> + "Configured %pC clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n",
>> + fsl_ldb->clk, configured_link_freq, requested_link_freq);
>
> commit message said show clock name, but %p is for pointer value. Are sure
> it show clock name?

%pC prints clock name. Please see Documentation/core-api/printk-formats.rst.

>
> Frank
>
>>
>> clk_prepare_enable(fsl_ldb->clk);
>>
>>
>> --
>> 2.48.1
>>

--
Regards,
Liu Ying