From: Lee Jones <lee@kernel.org>
To: Manuel Fombuena <fombuena@outlook.com>
Cc: pavel@ucw.cz, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN
Date: Fri, 7 Mar 2025 07:30:15 -0800 [thread overview]
Message-ID: <20250307153015.GF8350@google.com> (raw)
In-Reply-To: <CWLP123MB5473AFE2456779BF93951439C5D52@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM>
On Fri, 07 Mar 2025, Manuel Fombuena wrote:
> On Thu, 6 Mar 2025, Lee Jones wrote:
>
> > On Wed, 26 Feb 2025, Manuel Fombuena wrote:
> > > --- a/drivers/leds/Kconfig
> > > +++ b/drivers/leds/Kconfig
> > > @@ -971,6 +971,7 @@ config LEDS_ST1202
> > > depends on I2C
> > > depends on OF
> > > select LEDS_TRIGGERS
> > > + select LEDS_TRIGGER_PATTERN
> >
> > Don't you need both?
>
> Not sure I understand the question, sorry. The patch adds 'select
> LEDS_TRIGGER_PATTERN' to the existing 'select LEDS_TRIGGERS'. So yes, you
> need both.
>
> If the question were meant to be 'Do you need both?' the answer would have
> also been yes. Having only 'select LEDS_TRIGGER_PATTERN' doesn't select
> LEDS_TRIGGERS, and it would be even worse because you wouldn't have any of
> them. I tried that first, in case select LEDS_TRIGGER_PATTERN implicitly
> selects LEDS_TRIGGER, but it doesn't work like that.
Never mind. I misread the diff.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-03-07 15:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 17:04 [PATCH 0/3] leds-st1202 improvements Manuel Fombuena
2025-02-26 17:06 ` [PATCH 1/3] leds: leds-st1202: initialize hardware before DT node child operations Manuel Fombuena
2025-02-26 17:08 ` [PATCH 2/3] leds: leds-st1202: spacing and proofreading editing Manuel Fombuena
2025-02-26 17:12 ` [PATCH 3/3] leds: Kconfig: leds-st1202: add select for required LEDS_TRIGGER_PATTERN Manuel Fombuena
2025-03-06 23:47 ` Lee Jones
2025-03-07 11:34 ` Manuel Fombuena
2025-03-07 15:30 ` Lee Jones [this message]
2025-03-07 15:31 ` [PATCH 0/3] leds-st1202 improvements Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250307153015.GF8350@google.com \
--to=lee@kernel.org \
--cc=fombuena@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox