From: kernel test robot <lkp@intel.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>,
Jonathan Corbet <corbet@lwn.net>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-kselftest@vger.kernel.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>,
Stephen Hemminger <stephen@networkplumber.org>,
gur.stavi@huawei.com, Lei Yang <leiyang@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 3/6] tun: Introduce virtio-net hash feature
Date: Fri, 7 Mar 2025 19:50:12 +0800 [thread overview]
Message-ID: <202503071936.EzoojQZO-lkp@intel.com> (raw)
In-Reply-To: <20250306-rss-v8-3-7ab4f56ff423@daynix.com>
Hi Akihiko,
kernel test robot noticed the following build warnings:
[auto build test WARNING on dd83757f6e686a2188997cb58b5975f744bb7786]
url: https://github.com/intel-lab-lkp/linux/commits/Akihiko-Odaki/virtio_net-Add-functions-for-hashing/20250306-180546
base: dd83757f6e686a2188997cb58b5975f744bb7786
patch link: https://lore.kernel.org/r/20250306-rss-v8-3-7ab4f56ff423%40daynix.com
patch subject: [PATCH net-next v8 3/6] tun: Introduce virtio-net hash feature
config: x86_64-buildonly-randconfig-001-20250307 (https://download.01.org/0day-ci/archive/20250307/202503071936.EzoojQZO-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250307/202503071936.EzoojQZO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503071936.EzoojQZO-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/tap.c:1056:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
1056 | case SIOCGIFHWADDR:
| ^
drivers/net/tap.c:1056:2: note: insert '__attribute__((fallthrough));' to silence this warning
1056 | case SIOCGIFHWADDR:
| ^
| __attribute__((fallthrough));
drivers/net/tap.c:1056:2: note: insert 'break;' to avoid fall-through
1056 | case SIOCGIFHWADDR:
| ^
| break;
1 warning generated.
vim +1056 drivers/net/tap.c
2be5c76794b0e5 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 964
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 965 /*
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 966 * provide compatibility with generic tun/tap interface
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 967 */
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 968 static long tap_ioctl(struct file *file, unsigned int cmd,
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 969 unsigned long arg)
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 970 {
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 971 struct tap_queue *q = file->private_data;
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 972 struct tap_dev *tap;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 973 void __user *argp = (void __user *)arg;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 974 struct ifreq __user *ifr = argp;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 975 unsigned int __user *up = argp;
39ec7de7092ba9 drivers/net/macvtap.c Michael S. Tsirkin 2014-12-16 976 unsigned short u;
55afbd0810922a drivers/net/macvtap.c Michael S. Tsirkin 2010-04-29 977 int __user *sp = argp;
7f460d30c8e130 drivers/net/macvtap.c Justin Cormack 2015-05-13 978 struct sockaddr sa;
55afbd0810922a drivers/net/macvtap.c Michael S. Tsirkin 2010-04-29 979 int s;
02df55d28c6001 drivers/net/macvtap.c Arnd Bergmann 2010-02-18 980 int ret;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 981
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 982 switch (cmd) {
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 983 case TUNSETIFF:
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 984 /* ignore the name, just look at flags */
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 985 if (get_user(u, &ifr->ifr_flags))
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 986 return -EFAULT;
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 987
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 988 ret = 0;
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 989 if ((u & ~TAP_IFFEATURES) != (IFF_NO_PI | IFF_TAP))
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 990 ret = -EINVAL;
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 991 else
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 992 q->flags = (q->flags & ~TAP_IFFEATURES) | u;
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 993
b9fb9ee07e67fc drivers/net/macvtap.c Arnd Bergmann 2010-02-18 994 return ret;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 995
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 996 case TUNGETIFF:
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 997 rtnl_lock();
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 998 tap = tap_get_tap_dev(q);
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 999 if (!tap) {
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1000 rtnl_unlock();
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1001 return -ENOLINK;
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1002 }
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1003
02df55d28c6001 drivers/net/macvtap.c Arnd Bergmann 2010-02-18 1004 ret = 0;
39ec7de7092ba9 drivers/net/macvtap.c Michael S. Tsirkin 2014-12-16 1005 u = q->flags;
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1006 if (copy_to_user(&ifr->ifr_name, tap->dev->name, IFNAMSIZ) ||
39ec7de7092ba9 drivers/net/macvtap.c Michael S. Tsirkin 2014-12-16 1007 put_user(u, &ifr->ifr_flags))
02df55d28c6001 drivers/net/macvtap.c Arnd Bergmann 2010-02-18 1008 ret = -EFAULT;
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1009 tap_put_tap_dev(tap);
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1010 rtnl_unlock();
02df55d28c6001 drivers/net/macvtap.c Arnd Bergmann 2010-02-18 1011 return ret;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1012
815f236d622721 drivers/net/macvtap.c Jason Wang 2013-06-05 1013 case TUNSETQUEUE:
815f236d622721 drivers/net/macvtap.c Jason Wang 2013-06-05 1014 if (get_user(u, &ifr->ifr_flags))
815f236d622721 drivers/net/macvtap.c Jason Wang 2013-06-05 1015 return -EFAULT;
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1016 rtnl_lock();
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 1017 ret = tap_ioctl_set_queue(file, u);
441ac0fcaadc76 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1018 rtnl_unlock();
82a19eb8c02ab9 drivers/net/macvtap.c Jason Wang 2013-07-16 1019 return ret;
815f236d622721 drivers/net/macvtap.c Jason Wang 2013-06-05 1020
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1021 case TUNGETFEATURES:
635b8c8ecdd271 drivers/net/tap.c Sainath Grandhi 2017-02-10 1022 if (put_user(IFF_TAP | IFF_NO_PI | TAP_IFFEATURES, up))
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1023 return -EFAULT;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1024 return 0;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1025
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1026 case TUNSETSNDBUF:
3ea79249e81e5e drivers/net/macvtap.c Michael S. Tsirkin 2015-09-18 1027 if (get_user(s, sp))
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1028 return -EFAULT;
93161922c658c7 drivers/net/tap.c Craig Gallek 2017-10-30 1029 if (s <= 0)
93161922c658c7 drivers/net/tap.c Craig Gallek 2017-10-30 1030 return -EINVAL;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1031
3ea79249e81e5e drivers/net/macvtap.c Michael S. Tsirkin 2015-09-18 1032 q->sk.sk_sndbuf = s;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1033 return 0;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1034
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1035 case TUNSETOFFLOAD:
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1036 /* let the user check for future flags */
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1037 if (arg & ~(TUN_F_CSUM | TUN_F_TSO4 | TUN_F_TSO6 |
399e0827642f6a drivers/net/tap.c Andrew Melnychenko 2022-12-07 1038 TUN_F_TSO_ECN | TUN_F_UFO |
399e0827642f6a drivers/net/tap.c Andrew Melnychenko 2022-12-07 1039 TUN_F_USO4 | TUN_F_USO6))
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1040 return -EINVAL;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1041
2be5c76794b0e5 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1042 rtnl_lock();
2be5c76794b0e5 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1043 ret = set_offload(q, arg);
2be5c76794b0e5 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1044 rtnl_unlock();
2be5c76794b0e5 drivers/net/macvtap.c Vlad Yasevich 2013-06-25 1045 return ret;
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1046
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1047 case TUNGETVNETHASHCAP:
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1048 return tun_vnet_ioctl_gethashcap(argp);
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1049
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1050 case TUNSETVNETHASH:
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1051 rtnl_lock();
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1052 tap = rtnl_dereference(q->tap);
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1053 ret = tap ? tun_vnet_ioctl_sethash(&tap->vnet_hash, true, argp) : -EBADFD;
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1054 rtnl_unlock();
2c592c9b450ea4 drivers/net/tap.c Akihiko Odaki 2025-03-06 1055
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 @1056 case SIOCGIFHWADDR:
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1057 rtnl_lock();
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1058 tap = tap_get_tap_dev(q);
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1059 if (!tap) {
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1060 rtnl_unlock();
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1061 return -ENOLINK;
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1062 }
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1063 ret = 0;
3b23a32a63219f drivers/net/tap.c Cong Wang 2021-02-11 1064 dev_get_mac_address(&sa, dev_net(tap->dev), tap->dev->name);
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1065 if (copy_to_user(&ifr->ifr_name, tap->dev->name, IFNAMSIZ) ||
3b23a32a63219f drivers/net/tap.c Cong Wang 2021-02-11 1066 copy_to_user(&ifr->ifr_hwaddr, &sa, sizeof(sa)))
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1067 ret = -EFAULT;
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1068 tap_put_tap_dev(tap);
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1069 rtnl_unlock();
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1070 return ret;
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1071
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1072 case SIOCSIFHWADDR:
7f460d30c8e130 drivers/net/macvtap.c Justin Cormack 2015-05-13 1073 if (copy_from_user(&sa, &ifr->ifr_hwaddr, sizeof(sa)))
7f460d30c8e130 drivers/net/macvtap.c Justin Cormack 2015-05-13 1074 return -EFAULT;
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1075 rtnl_lock();
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1076 tap = tap_get_tap_dev(q);
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1077 if (!tap) {
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1078 rtnl_unlock();
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1079 return -ENOLINK;
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1080 }
3b23a32a63219f drivers/net/tap.c Cong Wang 2021-02-11 1081 ret = dev_set_mac_address_user(tap->dev, &sa, NULL);
6fe3faf86757eb drivers/net/tap.c Sainath Grandhi 2017-02-10 1082 tap_put_tap_dev(tap);
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1083 rtnl_unlock();
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1084 return ret;
b5082083392224 drivers/net/macvtap.c Justin Cormack 2015-05-11 1085
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1086 default:
69113cb5de68da drivers/net/tap.c Akihiko Odaki 2025-02-07 1087 return tun_vnet_ioctl(&q->vnet_hdr_sz, &q->flags, cmd, sp);
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1088 }
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1089 }
20d29d7a916a47 drivers/net/macvtap.c Arnd Bergmann 2010-01-30 1090
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-03-07 11:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 9:56 [PATCH net-next v8 0/6] tun: Introduce virtio-net hashing feature Akihiko Odaki
2025-03-06 9:56 ` [PATCH net-next v8 1/6] virtio_net: Add functions for hashing Akihiko Odaki
2025-03-06 9:56 ` [PATCH net-next v8 2/6] net: flow_dissector: Export flow_keys_dissector_symmetric Akihiko Odaki
2025-03-06 9:56 ` [PATCH net-next v8 3/6] tun: Introduce virtio-net hash feature Akihiko Odaki
2025-03-07 1:55 ` Jakub Kicinski
2025-03-07 11:50 ` kernel test robot [this message]
2025-03-06 9:56 ` [PATCH net-next v8 4/6] selftest: tun: Test vnet ioctls without device Akihiko Odaki
2025-03-06 9:56 ` [PATCH net-next v8 5/6] selftest: tun: Add tests for virtio-net hashing Akihiko Odaki
2025-03-06 9:56 ` [PATCH net-next v8 6/6] vhost/net: Support VIRTIO_NET_F_HASH_REPORT Akihiko Odaki
2025-03-07 8:15 ` [PATCH net-next v8 0/6] tun: Introduce virtio-net hashing feature Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202503071936.EzoojQZO-lkp@intel.com \
--to=lkp@intel.com \
--cc=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gur.stavi@huawei.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leiyang@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox