The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
To: joe@perches.com
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
	aliceryhl@google.com, apw@canonical.com, arnd@arndb.de,
	aswinunni01@gmail.com, axboe@kernel.dk, benno.lossin@proton.me,
	bhelgaas@google.com, bjorn3_gh@protonmail.com,
	boqun.feng@gmail.com, charmitro@posteo.net, dakr@kernel.org,
	dwaipayanray1@gmail.com, ethan.twardy@gmail.com,
	fujita.tomonori@gmail.com, gary@garyguo.net,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	lukas.bulwahn@gmail.com, ojeda@kernel.org, pbonzini@redhat.com,
	rust-for-linux@vger.kernel.org, tmgross@umich.edu,
	trintaeoitogc@gmail.com, walmeida@microsoft.com
Subject: Re: [PATCH V9 2/2] checkpatch: check format of Vec<String> in modules
Date: Mon, 10 Mar 2025 10:06:50 -0300	[thread overview]
Message-ID: <20250310130650.855103-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <8f8c79c5f1c5508defdd4a4c020c2c8e60b95afb.camel@perches.com>

Joe Perches <joe@perches.com> wrote:
> What happens if the patch contains more than one module?
Sincerely I do not was test this. I don't was think about when the patch
contains more than one module, is a critical problem that went unnoticed by me.
Thanks for noticing this.
I will make some tests for this and make some changes if neccessary.

> spaces contains both spaces and tabs.
> Why not test the strings rather than the length?
> Otherwise tab-space is the same length as space-tab.
You is right, we can test the string rather than length. 

> Why is herevet_space_add more useful than herevet?
The $herevet_space_add store the $herevet for the added line. Otherwise, if the
change is like:
authors: [
+	 author_1
	author_2
	author_3
]
The $expected_spaces and $spaces will be filled in the "author_2" line. And the
content of $herevet will be "	author_2" rather than "+	 author_1".

How the rust-side patch already is merged in rust-next, I only will send a
patch for this checkpatch.
I will make this changes that you suggested for me, and send a new patch.

Thanks,
Guilherme

      reply	other threads:[~2025-03-10 13:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-09 17:57 [PATCH V9 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-03-09 17:57 ` [PATCH V9 1/2] rust: module: change author to an array Guilherme Giacomo Simoes
2025-03-09 22:42   ` Miguel Ojeda
2025-03-10  0:45   ` Miguel Ojeda
2025-03-09 17:57 ` [PATCH V9 2/2] checkpatch: check format of Vec<String> in modules Guilherme Giacomo Simoes
2025-03-10  6:36   ` Joe Perches
2025-03-10 13:06     ` Guilherme Giacomo Simoes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310130650.855103-1-trintaeoitogc@gmail.com \
    --to=trintaeoitogc@gmail.com \
    --cc=a.hindborg@kernel.org \
    --cc=alex.gaynor@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=apw@canonical.com \
    --cc=arnd@arndb.de \
    --cc=aswinunni01@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=benno.lossin@proton.me \
    --cc=bhelgaas@google.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=charmitro@posteo.net \
    --cc=dakr@kernel.org \
    --cc=dwaipayanray1@gmail.com \
    --cc=ethan.twardy@gmail.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    --cc=walmeida@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox