From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E84F1386DA for ; Tue, 11 Mar 2025 21:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741727009; cv=none; b=V8MQEU4cK9z0RaLRamDs/NpYT2RVFpWooefHtiEpspgDIghOlASZuVPS+qHpmz9iTpujv9zL9/KgHXJYEUQ2wycv8BdpcMHkBeBwCDmfZQWSJmJZRezCgwpat8TBFa5lD/WBGoK/BJ1cyvj0lgm+auMr9JYin4HFhgzB6XHUTzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741727009; c=relaxed/simple; bh=s9tR6nZeVVojY6KvUwD1l+egtg49JohWo9DDH5W6I2E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aJUzOpxn16ARS7icq3dru1U4/K3ikSmIu+LMUU0+AwJumqYhRW5u+xi5uCKjhPNY7VURSLSVTGmkVVZqiTj7vTqoPXomoh19Klce6F9GQFG6rCL5c2aqa3W+sRVA9ZLHx1Ug1R5veIIMMeKh0LFxiy909hIMGJl/YD/givXjCXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VG9an/u6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VG9an/u6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AC0CC4CEE9; Tue, 11 Mar 2025 21:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741727008; bh=s9tR6nZeVVojY6KvUwD1l+egtg49JohWo9DDH5W6I2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VG9an/u6VOWdNVuBbI8PXIYU60rcz47713Xas41H21yYPzyLBVmegAaQyN99aRFGv tdDHR03l6gtg5xax/NYkSxu3/W3Ri8ZjeR9eXREpYBRurQ3GZ0zJcys7Yy6mG2cLSv ma7amIPz4d8KuxbyTgl9Uq8W3uNxirHGq7ilqpD3AVM3sOyYJMLwpVL2jiO9yxhL1r HqqVJsR4cFzhpjE/fAqVxn7VKHWBiUHABVOr2dLcDWvxfCqd80rCvf0ldranITSwHQ qOA9Uu78CYQWJSaT36ssAwAdxBLvyU/k4AhG6gXigFncvASgy/QP42MJgL1WHL4VpZ iiQsRTNzCtjyQ== From: SeongJae Park To: Lorenzo Stoakes Cc: SeongJae Park , Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Shakeel Butt , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/9] mm/madvise: batch tlb flushes for MADV_DONTNEED and MADV_FREE Date: Tue, 11 Mar 2025 14:03:26 -0700 Message-Id: <20250311210326.85632-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <0f90d56e-5960-4478-803e-1054696c0cde@lucifer.local> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 11 Mar 2025 12:49:38 +0000 Lorenzo Stoakes wrote: > The below commit message talks about tlb bits, but you spend a lot of this > series refactoring mm/madvise.c. > > Can we just separate out the two into separate series please? > > I am doing the same kind of thing with mremap() at the moment, but sent the > refactor _first_ before the work that builds upon it :) > > Your refactoring is great, so I want to be able to take that (and Andrew's > objections obviously don't apply there), and then we can address tlb stuff > separately and in a more focused way. Thank you for the nice suggestion and I agree. I will separate those in the next spin. Thanks, SJ [...]