From: Ard Biesheuvel <ardb+git@google.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, hpa@zytor.com, mingo@kernel.org,
Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH] x86/boot: Add back some padding for the CRC-32 checksum
Date: Wed, 12 Mar 2025 09:12:05 +0100 [thread overview]
Message-ID: <20250312081204.521411-2-ardb+git@google.com> (raw)
From: Ard Biesheuvel <ardb@kernel.org>
Even though no uses of the bzImage CRC-32 checksum are known, ensure
that the last 4 bytes of the image are unused zero bytes, so that the
checksum can be generated post-build if needed.
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
As requested by hpa, this applies onto today's tip/x86/build
arch/x86/boot/compressed/vmlinux.lds.S | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
index 48d0b5184557..083ec6d7722a 100644
--- a/arch/x86/boot/compressed/vmlinux.lds.S
+++ b/arch/x86/boot/compressed/vmlinux.lds.S
@@ -48,7 +48,8 @@ SECTIONS
*(.data)
*(.data.*)
- . = ALIGN(0x200);
+ /* Add 4 bytes of extra space for a CRC-32 checksum */
+ . = ALIGN(. + 4, 0x200);
_edata = . ;
}
. = ALIGN(L1_CACHE_BYTES);
--
2.49.0.rc0.332.g42c0ae87b1-goog
next reply other threads:[~2025-03-12 8:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 8:12 Ard Biesheuvel [this message]
2025-03-12 12:09 ` [tip: x86/build] x86/boot: Add back some padding for the CRC-32 checksum tip-bot2 for Ard Biesheuvel
2025-04-14 13:56 ` Borislav Petkov
2025-04-14 14:07 ` Ard Biesheuvel
2025-04-15 17:00 ` H. Peter Anvin
2025-04-15 21:54 ` Borislav Petkov
2025-04-15 21:58 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312081204.521411-2-ardb+git@google.com \
--to=ardb+git@google.com \
--cc=ardb@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).