Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function

Mark Brown
2025-03-13T13:25:24Z

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

On Thu, Mar 13, 2025 at 01:20:36PM +0000, Lee Jones wrote:
> On Tue, 04 Mar 2025, Artur Weber wrote:

> > + if (id != bcm590xx->pmu_id) {
> > + dev_err(bcm590xx->dev,
> > + "Incorrect ID for %s: expected %x, got %x. Check your DT compatible.\n",
>
> Isn't it more likely that the H/W this is being executed on is
> unsupported? If so, say that instead.

Given that the compatibles are device specific the driver shouldn't be
binding if the device is unsupported.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]