Re: [PATCH v6 02/10] dt-bindings: mfd: brcm,bcm59056: Add compatible for BCM59054

Artur Weber
2025-03-05T16:52:16Z

On 4.03.2025 15:19, Rob Herring wrote:
> On Tue, Mar 04, 2025 at 07:20:33AM +0100, Artur Weber wrote:
>> The BCM59054 MFD is fairly similar to the BCM59056, and will use
>> the same driver. Add compatible and specify the allowed regulator
>> nodes.
>>
>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
>> ...
> And drop the allOf below.
>
>>
>> required:
>> - compatible
>> @@ -30,6 +31,27 @@ required:
>>
>> additionalProperties: false
>>
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: brcm,bcm59054
>> + then:
>> + properties:
>> + regulators:
>> + $ref: /schemas/regulator/brcm,bcm59054.yaml#
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + const: brcm,bcm59056
>> + then:
>> + properties:
>> + regulators:
>> + $ref: /schemas/regulator/brcm,bcm59056.yaml#
>> +
>> examples:
>> - |
>> #include <dt-bindings/interrupt-controller/arm-gic.h>

"Drop the allOf" as in, drop just the "allOf" line or the entire block
with "if" statements? If it's the latter - wouldn't that break the
bindings for the "regulators" subnode?

Best regards
Artur