From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E0FB1C07D9 for ; Thu, 13 Mar 2025 22:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741903695; cv=none; b=tpJ1b1y8MJ08M+TIF7EOUQCRvUmZ4CqTYE7rnQEvaZH7Cz8vLVa6ALbDWBKXSsLakJmmWQjHzGcYdX0uExkwf6OPxhhANDJce4CBODLwcd68xxicPfWl0wBU/leJxHih9TL0hfiZcvk05/n9sGNz3WZuvwfh0dSauiWV5+LDup0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741903695; c=relaxed/simple; bh=IRAhxhtjAxwlDedobD/rjMlDvajD+gS5Er4WmKzxIyY=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=pqm3FcMMkVysEPICFv4n/tn532LHzvYNxD/oO9fIuOFCiIJDSQVPh9kMGRWIGWmdkiV28xdDLb7QO4eE6C9ev3gWz63fccGP/LCgdPydy6TfHPyxcD2PKTPV5t5rO2GWTG/h8ycBPKmnDP1hVOEUw4SUbxutd6+Zs1a/DOYxTfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=zLYkXpMF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="zLYkXpMF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99306C4CEDD; Thu, 13 Mar 2025 22:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1741903695; bh=IRAhxhtjAxwlDedobD/rjMlDvajD+gS5Er4WmKzxIyY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zLYkXpMFOIhsH962rYF+opwrkkdhe+6kfeiby9XVU0T8+3ncLboKFq+oonTGkhsyf XrGwqB1PQSouvsvC49AgpspjqpipqKXkKuu8wEJKGpxspTMHxn48pjE7JY96uUbLOU GXRFqh3kodKoRV3NzdZmn+zRPPdwVbnEI984A90Y= Date: Thu, 13 Mar 2025 15:08:14 -0700 From: Andrew Morton To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?Andr=E9?= Almeida , Darren Hart , Davidlohr Bueso , Ingo Molnar , Juri Lelli , Peter Zijlstra , Thomas Gleixner , Valentin Schneider , Waiman Long , Uladzislau Rezki , Christoph Hellwig , linux-mm@kvack.org, Christoph Hellwig Subject: Re: [PATCH v10 19/21] mm: Add vmalloc_huge_node() Message-Id: <20250313150814.075d1cd993a84005d4cd22c2@linux-foundation.org> In-Reply-To: <20250313075924.qulV64zL@linutronix.de> References: <20250312151634.2183278-1-bigeasy@linutronix.de> <20250312151634.2183278-20-bigeasy@linutronix.de> <20250312150206.54afabcf993bbc55f0066886@linux-foundation.org> <20250313075924.qulV64zL@linutronix.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 13 Mar 2025 08:59:24 +0100 Sebastian Andrzej Siewior wrote: > > > > I suppose we can now simplify vmalloc_huge_noprof() to use this: > > > > static inline void *vmalloc_huge_noprof(unsigned long size, gfp_t gfp_mask) > > { > > return vmalloc_huge_node_noprof(size, gfp_mask, NUMA_NO_NODE); > > } > > Do you want me to stash this into this one or as a follow up? That would be nice, if you think it makes sense. There is some duplication here.