* [PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk()
@ 2025-03-13 16:14 Qasim Ijaz
2025-03-14 6:55 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Qasim Ijaz @ 2025-03-13 16:14 UTC (permalink / raw)
To: christian.koenig, ray.huang, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, thomas.hellstrom,
Arunpravin.PaneerSelvam, karolina.stolarek, jeff.johnson, bigeasy
Cc: dri-devel, linux-kernel
In the ttm_bo_unreserve_bulk() test function, resv is allocated using
kunit_kzalloc(), but the subsequent assertion mistakenly verifies the
ttm_dev pointer instead of the resv pointer.
Fix the assertion to properly verify the resv pointer.
Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
index f8f20d2f6174..e08e5a138420 100644
--- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
+++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
@@ -340,7 +340,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test)
KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL);
- KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
+ KUNIT_ASSERT_NOT_NULL(test, resv);
err = ttm_device_kunit_init(priv, ttm_dev, false, false);
KUNIT_ASSERT_EQ(test, err, 0);
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk()
2025-03-13 16:14 [PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk() Qasim Ijaz
@ 2025-03-14 6:55 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2025-03-14 6:55 UTC (permalink / raw)
To: Qasim Ijaz, ray.huang, maarten.lankhorst, mripard, tzimmermann,
airlied, simona, thomas.hellstrom, Arunpravin.PaneerSelvam,
karolina.stolarek, jeff.johnson, bigeasy
Cc: dri-devel, linux-kernel
Am 13.03.25 um 17:14 schrieb Qasim Ijaz:
> In the ttm_bo_unreserve_bulk() test function, resv is allocated using
> kunit_kzalloc(), but the subsequent assertion mistakenly verifies the
> ttm_dev pointer instead of the resv pointer.
>
> Fix the assertion to properly verify the resv pointer.
>
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
Reviewed and pushed.
Thanks,
Christian.
> ---
> drivers/gpu/drm/ttm/tests/ttm_bo_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> index f8f20d2f6174..e08e5a138420 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_bo_test.c
> @@ -340,7 +340,7 @@ static void ttm_bo_unreserve_bulk(struct kunit *test)
> KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
>
> resv = kunit_kzalloc(test, sizeof(*resv), GFP_KERNEL);
> - KUNIT_ASSERT_NOT_NULL(test, ttm_dev);
> + KUNIT_ASSERT_NOT_NULL(test, resv);
>
> err = ttm_device_kunit_init(priv, ttm_dev, false, false);
> KUNIT_ASSERT_EQ(test, err, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-14 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 16:14 [PATCH] drm/ttm/tests: fix incorrect assert in ttm_bo_unreserve_bulk() Qasim Ijaz
2025-03-14 6:55 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox