Re: [PATCH v6 05/26] drm/debugfs: add top-level 'bridges' file showing all added bridges

Luca Ceresoli
2025-02-07T08:54:28Z

Hi Dmitry,

On Fri, 7 Feb 2025 04:41:12 +0200
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote:

> On Thu, Feb 06, 2025 at 07:14:20PM +0100, Luca Ceresoli wrote:
> > The global bridges_list holding all the bridges between drm_bridge_add()
> > and drm_bridge_remove() cannot be inspected via debugfs. Add a file showing
> > it.
> >
> > To avoid code duplication, move the code printing a bridge info to a common
> > function.
> >
> > Note: this change requires exporting bridge_list and the mutex protecting
> > it.
> >
> > Also add a comment about bridge_lock to make checkpatch happy.
>
> I think, exporting mutex _and_ a list is a bad idea (especially since
> they don't have a proper prefix). It might be better to make the
> bridge_print() function a more public one (and name it
> drm_bridge_print()) and move allbridges attribute definition to
> drm_bridge.c

I was also not happy with exporting these two symbols, and agree
exporting a print function from drm_bridge.c is cleaner. I'll rearrange
this for v7.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering