Re: [PATCH v2 01/15] cxl: Modify address translation callback for generic use

Dave Jiang
2025-02-20T21:03:44Z

On 2/20/25 9:00 AM, Gregory Price wrote:
> On Tue, Feb 18, 2025 at 02:23:42PM +0100, Robert Richter wrote:
>> The root decoder address translation callback could be reused for
>> other decoders too. For generic use of the callback, change the
>> function interface to use a decoder argument instead of the root
>> decoder.
>>
>> Note that a root decoder's HPA is equal to its SPA, but else it may be
>
> slighlty better wording:
> "but it may different for non-root decoders"

This change helped me understand what that sentence was trying to say.

>
>> different. Thus, change the name of the function type to
>> cxl_to_hpa_fn.

I would also drop the "thus" so it's in imperative tone.

>>
>> Signed-off-by: Robert Richter <rrichter@amd.com>
>
> Reviewed-by: Gregory Price <gourry@gourry.net>
>